You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Mohit Jaggi <mo...@gmail.com> on 2017/11/02 21:38:39 UTC
Re: Review Request 57524: Support setting the rootfs on Mesos
Containers.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57524/#review189970
-----------------------------------------------------------
Folks, Is this going to get committed?
- Mohit Jaggi
On March 13, 2017, 4:36 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57524/
> -----------------------------------------------------------
>
> (Updated March 13, 2017, 4:36 p.m.)
>
>
> Review request for Aurora, Santhosh Kumar Shanmugham and Stephan Erb.
>
>
> Bugs: AURORA-1903
> https://issues.apache.org/jira/browse/AURORA-1903
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The mesos unified containerizer does not support absolute container path mounts if no rootfs is set. This allows operators to switch between our current behaviour (mounting images as a volume) and setting the rootfs. See AURORA-1903 for more detailed analysis.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java f0b148cd158d61cd89cc51dca9f3fa4c6feb1b49
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java 4dac9757a65e144142d36ee921b85a02a5311fe5
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettings.java 5c987fd051728486172c8afd34219e86d56f00d5
> src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 0d639f66db456858278b0485c91c40975c3b45ac
> src/main/java/org/apache/aurora/scheduler/mesos/TestExecutorSettings.java e1cd81e6fbd98f23046e6e775be268be4310c62a
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 93cc34cf8393f969087cd0fd6f577228c00170e9
>
>
> Diff: https://reviews.apache.org/r/57524/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 57524: Support setting the rootfs on Mesos
Containers.
Posted by Jason Lai <ja...@jasonlai.net>.
> On Nov. 2, 2017, 9:38 p.m., Mohit Jaggi wrote:
> > Folks, Is this going to get committed?
>
> Stephan Erb wrote:
> I believe this breaks a few things when enabled (e.g. user creation). I will need to take a closer look next week.
>
> Jason Lai wrote:
> Thanks for the reply. We have been running this internally at Uber for a while and haven't seen broken user creation happening. Do you mind sharing a bit more specifics about what this could potentially break?
Bump
- Jason
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57524/#review189970
-----------------------------------------------------------
On March 13, 2017, 4:36 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57524/
> -----------------------------------------------------------
>
> (Updated March 13, 2017, 4:36 p.m.)
>
>
> Review request for Aurora, Santhosh Kumar Shanmugham and Stephan Erb.
>
>
> Bugs: AURORA-1903
> https://issues.apache.org/jira/browse/AURORA-1903
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The mesos unified containerizer does not support absolute container path mounts if no rootfs is set. This allows operators to switch between our current behaviour (mounting images as a volume) and setting the rootfs. See AURORA-1903 for more detailed analysis.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java f0b148cd158d61cd89cc51dca9f3fa4c6feb1b49
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java 4dac9757a65e144142d36ee921b85a02a5311fe5
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettings.java 5c987fd051728486172c8afd34219e86d56f00d5
> src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 0d639f66db456858278b0485c91c40975c3b45ac
> src/main/java/org/apache/aurora/scheduler/mesos/TestExecutorSettings.java e1cd81e6fbd98f23046e6e775be268be4310c62a
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 93cc34cf8393f969087cd0fd6f577228c00170e9
>
>
> Diff: https://reviews.apache.org/r/57524/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 57524: Support setting the rootfs on Mesos
Containers.
Posted by Jason Lai <ja...@jasonlai.net>.
> On Nov. 2, 2017, 9:38 p.m., Mohit Jaggi wrote:
> > Folks, Is this going to get committed?
>
> Stephan Erb wrote:
> I believe this breaks a few things when enabled (e.g. user creation). I will need to take a closer look next week.
Thanks for the reply. We have been running this internally at Uber for a while and haven't seen broken user creation happening. Do you mind sharing a bit more specifics about what this could potentially break?
- Jason
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57524/#review189970
-----------------------------------------------------------
On March 13, 2017, 4:36 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57524/
> -----------------------------------------------------------
>
> (Updated March 13, 2017, 4:36 p.m.)
>
>
> Review request for Aurora, Santhosh Kumar Shanmugham and Stephan Erb.
>
>
> Bugs: AURORA-1903
> https://issues.apache.org/jira/browse/AURORA-1903
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The mesos unified containerizer does not support absolute container path mounts if no rootfs is set. This allows operators to switch between our current behaviour (mounting images as a volume) and setting the rootfs. See AURORA-1903 for more detailed analysis.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java f0b148cd158d61cd89cc51dca9f3fa4c6feb1b49
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java 4dac9757a65e144142d36ee921b85a02a5311fe5
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettings.java 5c987fd051728486172c8afd34219e86d56f00d5
> src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 0d639f66db456858278b0485c91c40975c3b45ac
> src/main/java/org/apache/aurora/scheduler/mesos/TestExecutorSettings.java e1cd81e6fbd98f23046e6e775be268be4310c62a
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 93cc34cf8393f969087cd0fd6f577228c00170e9
>
>
> Diff: https://reviews.apache.org/r/57524/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 57524: Support setting the rootfs on Mesos Containers.
Posted by Mohit Jaggi <mo...@gmail.com>.
Thanks Stephan.
On Fri, Nov 3, 2017 at 11:05 AM, Stephan Erb <se...@apache.org> wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57524/
>
> On November 2nd, 2017, 10:38 p.m. CET, *Mohit Jaggi* wrote:
>
> Folks, Is this going to get committed?
>
> I believe this breaks a few things when enabled (e.g. user creation). I will need to take a closer look next week.
>
>
> - Stephan
>
> On March 13th, 2017, 5:36 p.m. CET, Zameer Manji wrote:
> Review request for Aurora, Santhosh Kumar Shanmugham and Stephan Erb.
> By Zameer Manji.
>
> *Updated March 13, 2017, 5:36 p.m.*
> *Bugs: * AURORA-1903 <https://issues.apache.org/jira/browse/AURORA-1903>
> *Repository: * aurora
> Description
>
> The mesos unified containerizer does not support absolute container path mounts if no rootfs is set. This allows operators to switch between our current behaviour (mounting images as a volume) and setting the rootfs. See AURORA-1903 for more detailed analysis.
>
> Diffs
>
> - src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java (
> f0b148cd158d61cd89cc51dca9f3fa4c6feb1b49)
> - src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java
> (4dac9757a65e144142d36ee921b85a02a5311fe5)
> - src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettings.java
> (5c987fd051728486172c8afd34219e86d56f00d5)
> - src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java
> (0d639f66db456858278b0485c91c40975c3b45ac)
> - src/main/java/org/apache/aurora/scheduler/mesos/TestExecutorSettings.java
> (e1cd81e6fbd98f23046e6e775be268be4310c62a)
> - src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java
> (93cc34cf8393f969087cd0fd6f577228c00170e9)
>
> View Diff <https://reviews.apache.org/r/57524/diff/1/>
>
Re: Review Request 57524: Support setting the rootfs on Mesos
Containers.
Posted by Stephan Erb <se...@apache.org>.
> On Nov. 2, 2017, 10:38 p.m., Mohit Jaggi wrote:
> > Folks, Is this going to get committed?
I believe this breaks a few things when enabled (e.g. user creation). I will need to take a closer look next week.
- Stephan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57524/#review189970
-----------------------------------------------------------
On March 13, 2017, 5:36 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57524/
> -----------------------------------------------------------
>
> (Updated March 13, 2017, 5:36 p.m.)
>
>
> Review request for Aurora, Santhosh Kumar Shanmugham and Stephan Erb.
>
>
> Bugs: AURORA-1903
> https://issues.apache.org/jira/browse/AURORA-1903
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The mesos unified containerizer does not support absolute container path mounts if no rootfs is set. This allows operators to switch between our current behaviour (mounting images as a volume) and setting the rootfs. See AURORA-1903 for more detailed analysis.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java f0b148cd158d61cd89cc51dca9f3fa4c6feb1b49
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java 4dac9757a65e144142d36ee921b85a02a5311fe5
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettings.java 5c987fd051728486172c8afd34219e86d56f00d5
> src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 0d639f66db456858278b0485c91c40975c3b45ac
> src/main/java/org/apache/aurora/scheduler/mesos/TestExecutorSettings.java e1cd81e6fbd98f23046e6e775be268be4310c62a
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 93cc34cf8393f969087cd0fd6f577228c00170e9
>
>
> Diff: https://reviews.apache.org/r/57524/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>