You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by su...@apache.org on 2023/04/02 08:48:21 UTC

[shardingsphere] branch master updated: Refactor StandardReadwriteSplittingDataSourceRouterTest (#24952)

This is an automated email from the ASF dual-hosted git repository.

sunnianjun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 06d5c6ece39 Refactor StandardReadwriteSplittingDataSourceRouterTest (#24952)
06d5c6ece39 is described below

commit 06d5c6ece39fc51313d378d6c35495e90cd63a9e
Author: Liang Zhang <zh...@apache.org>
AuthorDate: Sun Apr 2 16:48:14 2023 +0800

    Refactor StandardReadwriteSplittingDataSourceRouterTest (#24952)
    
    * Refactor StandardReadwriteSplittingDataSourceRouterTest
---
 .../StandardReadwriteSplittingDataSourceRouterTest.java     | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/features/readwrite-splitting/core/src/test/java/org/apache/shardingsphere/readwritesplitting/route/standard/StandardReadwriteSplittingDataSourceRouterTest.java b/features/readwrite-splitting/core/src/test/java/org/apache/shardingsphere/readwritesplitting/route/standard/StandardReadwriteSplittingDataSourceRouterTest.java
index a6c3452d7c1..af7d2b0cd9d 100644
--- a/features/readwrite-splitting/core/src/test/java/org/apache/shardingsphere/readwritesplitting/route/standard/StandardReadwriteSplittingDataSourceRouterTest.java
+++ b/features/readwrite-splitting/core/src/test/java/org/apache/shardingsphere/readwritesplitting/route/standard/StandardReadwriteSplittingDataSourceRouterTest.java
@@ -30,29 +30,26 @@ import java.util.Arrays;
 import static org.hamcrest.CoreMatchers.is;
 import static org.hamcrest.MatcherAssert.assertThat;
 
-public class StandardReadwriteSplittingDataSourceRouterTest {
+class StandardReadwriteSplittingDataSourceRouterTest {
     
     private ReadwriteSplittingDataSourceRule rule;
     
-    private StandardReadwriteSplittingDataSourceRouter router;
-    
     @BeforeEach
     void setUp() {
         rule = new ReadwriteSplittingDataSourceRule(
                 new ReadwriteSplittingDataSourceRuleConfiguration("test_config",
                         new StaticReadwriteSplittingStrategyConfiguration("write_ds", Arrays.asList("read_ds_0", "read_ds_1")), TransactionalReadQueryStrategy.DYNAMIC, null),
                 TransactionalReadQueryStrategy.DYNAMIC, new RoundRobinReadQueryLoadBalanceAlgorithm());
-        router = new StandardReadwriteSplittingDataSourceRouter();
     }
     
     @Test
-    void assertGetReadDataSource() {
-        assertThat(router.route(rule), is("read_ds_0"));
+    void assertRoute() {
+        assertThat(new StandardReadwriteSplittingDataSourceRouter().route(rule), is("read_ds_0"));
     }
     
     @Test
-    void assertGetReadDataSourceWithFilter() {
+    void assertRouteWithFilter() {
         rule.updateDisabledDataSourceNames("read_ds_0", true);
-        assertThat(router.route(rule), is("read_ds_1"));
+        assertThat(new StandardReadwriteSplittingDataSourceRouter().route(rule), is("read_ds_1"));
     }
 }