You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2017/02/15 20:55:55 UTC

[kudu-CR] java: rename GetMasterRegistration -> ConnectToCluster/ConnectToMaster 

Hello Jean-Daniel Cryans,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/6018

to review the following change.

Change subject: java: rename GetMasterRegistration -> ConnectToCluster/ConnectToMaster
......................................................................

java: rename GetMasterRegistration -> ConnectToCluster/ConnectToMaster

This is just a straight Eclipse-driven rename. Actual functional changes
to follow.

Change-Id: Ia8c326f1c0e664f0a2098179af359b2735a442eb
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
R java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java
R java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToClusterResponse.java
R java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToMasterRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/TabletClient.java
R java/kudu-client/src/test/java/org/apache/kudu/client/TestConnectToCluster.java
6 files changed, 37 insertions(+), 37 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/6018/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6018
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia8c326f1c0e664f0a2098179af359b2735a442eb
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>

[kudu-CR] java: rename GetMasterRegistration -> ConnectToCluster/ConnectToMaster

Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.

Change subject: java: rename GetMasterRegistration -> ConnectToCluster/ConnectToMaster
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/6018
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8c326f1c0e664f0a2098179af359b2735a442eb
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] java: rename GetMasterRegistration -> ConnectToCluster/ConnectToMaster

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: java: rename GetMasterRegistration -> ConnectToCluster/ConnectToMaster
......................................................................


Patch Set 3: Code-Review+2

Carrying +2 from earlier pre-rebase

-- 
To view, visit http://gerrit.cloudera.org:8080/6018
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8c326f1c0e664f0a2098179af359b2735a442eb
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] java: rename GetMasterRegistration -> ConnectToCluster/ConnectToMaster

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.

Change subject: java: rename GetMasterRegistration -> ConnectToCluster/ConnectToMaster
......................................................................


java: rename GetMasterRegistration -> ConnectToCluster/ConnectToMaster

This is just a straight Eclipse-driven rename. Actual functional changes
to follow.

Change-Id: Ia8c326f1c0e664f0a2098179af359b2735a442eb
Reviewed-on: http://gerrit.cloudera.org:8080/6018
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
R java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java
R java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToClusterResponse.java
R java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToMasterRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/TabletClient.java
R java/kudu-client/src/test/java/org/apache/kudu/client/TestConnectToCluster.java
6 files changed, 37 insertions(+), 37 deletions(-)

Approvals:
  Todd Lipcon: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/6018
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia8c326f1c0e664f0a2098179af359b2735a442eb
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>