You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudberry.apache.org by re...@apache.org on 2025/01/23 14:13:35 UTC
(cloudberry) 15/16: Remove a fixme of pg_upgrade makefile
This is an automated email from the ASF dual-hosted git repository.
reshke pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudberry.git
commit b0e172bf358bcb513f37168df419967df1dd1600
Author: Adam Lee <ad...@gmail.com>
AuthorDate: Mon Mar 18 13:55:58 2024 +0800
Remove a fixme of pg_upgrade makefile
installcheck was always a no-op for pg_upgrade until PostgreSQL 15
switched tests to TAP.
Remove the fixme.
---
src/bin/pg_upgrade/Makefile | 6 ------
1 file changed, 6 deletions(-)
diff --git a/src/bin/pg_upgrade/Makefile b/src/bin/pg_upgrade/Makefile
index e0bf223994..cdf40b3b41 100644
--- a/src/bin/pg_upgrade/Makefile
+++ b/src/bin/pg_upgrade/Makefile
@@ -59,12 +59,6 @@ clean distclean maintainer-clean:
greenplum/aomd_filehandler.c: $(top_srcdir)/src/backend/access/appendonly/aomd_filehandler.c
rm -f $@ && cd greenplum && $(LN_S) ../$< aomd_filehandler.c
-# GPDB_95_MERGE_FIXME:
-# GPDB want to run installcheck of pg_upgrade in the end of installcheck-world
-# let installcheck be a no-op, so "make -C src/bin/ installcheck" does nothing on
-# src/bin/pg_upgrade, the real test of pg_upgrade will be triggered by
-# "make check" in the end of installcheck-world, see GNUmakefile.in
-
# When $(MAKE) is present, make automatically infers that this is a
# recursive make. which is not actually what we want here, as that
# e.g. prevents output synchronization from working (as make thinks
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org