You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/03/11 08:51:44 UTC

[GitHub] [lucene] mocobeta commented on pull request #740: LUCENE-10393: Unify binary dictionary and dictionary writer in kuromoji and nori

mocobeta commented on pull request #740:
URL: https://github.com/apache/lucene/pull/740#issuecomment-1064902141


   > I ran ./gradlew regenerate --rerun-tasks on your branch as an additional test and all binary data files were unchanged. So I feel good about correctness!
   
   Thanks, @rmuir for confirming that! This is code refactoring and shouldn't change the outputs of the BinaryDictionaryWriter.
   
   About the interface,  `MorphData` sounds fine to me if `Attributes` is confusing. I'll rename the classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org