[GitHub] [arrow-adbc] tokoko commented on a diff in pull request #605: feat(java/driver/flight-sql): implement getObjects

["tokoko (via GitHub)" <gi...@apache.org>]

tokoko commented on code in PR #605:
URL: https://github.com/apache/arrow-adbc/pull/605#discussion_r1175761832


##########
java/driver/validation/src/main/java/org/apache/arrow/adbc/driver/testsuite/AbstractTransactionTest.java:
##########
@@ -147,7 +147,7 @@ void commit() throws Exception {
   }
 
   @Test
-  void enableAutoCommitAlsoCommits() throws Exception {
+  public void enableAutoCommitAlsoCommits() throws Exception {

Review Comment:
   I think that's only the case if you don't need to override them in a subclass. In this case, I needed to disable them, that's why I added public. They can be changed to protected if it matters, but that should probably apply to all the other tests as well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org