You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "Shuai Zhang (JIRA)" <ji...@apache.org> on 2016/08/22 01:59:20 UTC
[jira] [Closed] (KAFKA-4053) Refactor TopicCommand to remove
redundant if/else statements
[ https://issues.apache.org/jira/browse/KAFKA-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shuai Zhang closed KAFKA-4053.
------------------------------
This issue is solved by pull request: https://github.com/apache/kafka/pull/1751
> Refactor TopicCommand to remove redundant if/else statements
> ------------------------------------------------------------
>
> Key: KAFKA-4053
> URL: https://issues.apache.org/jira/browse/KAFKA-4053
> Project: Kafka
> Issue Type: Improvement
> Components: admin
> Affects Versions: 0.10.0.1
> Reporter: Shuai Zhang
> Priority: Minor
> Fix For: 0.10.1.0
>
>
> In TopicCommand, there are a lot of redundant if/else statements, such as
> ```val ifNotExists = if (opts.options.has(opts.ifNotExistsOpt)) true else false```
> We can refactor it as the following statement:
> ```val ifNotExists = opts.options.has(opts.ifNotExistsOpt)```
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)