You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2021/10/25 03:02:19 UTC

[GitHub] [couchdb] nickva commented on a change in pull request #3799: Eliminate eunit compiler warnings

nickva commented on a change in pull request #3799:
URL: https://github.com/apache/couchdb/pull/3799#discussion_r735227502



##########
File path: src/dreyfus/test/dreyfus_purge_test.erl
##########
@@ -703,9 +705,8 @@ test_purge_search() ->
 
 %private API
 db_name() ->
-    Nums = tuple_to_list(erlang:now()),
     Prefix = "test-db",
-    Suffix = lists:concat([integer_to_list(Num) || Num <- Nums]),
+    Suffix = integer_to_list(erlang:system_time()),

Review comment:
       Theoretically I think there is a difference between the two. `now/0` should be strictly monotonically increasing while `system_time/0` might repeat its value. However this is for a test and it looks like we're cleaning up the dbs properly anyway so not a big deal.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org