[GitHub] [spark] MaxGekk commented on a change in pull request #28593: [SPARK-31710][SQL] Add two compatibility flag to cast long to timestamp

[GitBox <gi...@apache.org>]

MaxGekk commented on a change in pull request #28593:
URL: https://github.com/apache/spark/pull/28593#discussion_r427939888



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##########
@@ -59,8 +59,8 @@ object Cast {
     case (StringType, TimestampType) => true
     case (BooleanType, TimestampType) => true
     case (DateType, TimestampType) => true
-    case (_: NumericType, TimestampType) => true
-
+    case (_: NumericType, TimestampType) => if ( SQLConf.get.numericConvertToTimestampEnable ) true

Review comment:
       Just `SQLConf.get.numericConvertToTimestampEnable`?

##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##########
@@ -266,7 +266,12 @@ abstract class CastBase extends UnaryExpression with TimeZoneAwareExpression wit
       TypeCheckResult.TypeCheckSuccess
     } else {
       TypeCheckResult.TypeCheckFailure(
-        s"cannot cast ${child.dataType.catalogString} to ${dataType.catalogString}")
+        if ( child.dataType.isInstanceOf[NumericType] && dataType.isInstanceOf[TimestampType]) {

Review comment:
       Please, remove spaces:
   ```scala
   if (child.dataType.isInstanceOf[NumericType] && dataType.isInstanceOf[TimestampType])
   ```
   Take a look at the style guide: https://github.com/databricks/scala-style-guide




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org