You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@brooklyn.apache.org by he...@apache.org on 2018/11/30 15:39:58 UTC
[3/3] brooklyn-ui git commit: add comments re adding unlisted
parameters
add comments re adding unlisted parameters
Project: http://git-wip-us.apache.org/repos/asf/brooklyn-ui/repo
Commit: http://git-wip-us.apache.org/repos/asf/brooklyn-ui/commit/ef3ee091
Tree: http://git-wip-us.apache.org/repos/asf/brooklyn-ui/tree/ef3ee091
Diff: http://git-wip-us.apache.org/repos/asf/brooklyn-ui/diff/ef3ee091
Branch: refs/heads/master
Commit: ef3ee09169dc3aa7ffb5ed5843933c5911683393
Parents: cb00172
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Authored: Fri Nov 30 15:39:35 2018 +0000
Committer: Alex Heneveld <al...@cloudsoftcorp.com>
Committed: Fri Nov 30 15:39:35 2018 +0000
----------------------------------------------------------------------
.../app/components/providers/blueprint-service.provider.js | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/brooklyn-ui/blob/ef3ee091/ui-modules/blueprint-composer/app/components/providers/blueprint-service.provider.js
----------------------------------------------------------------------
diff --git a/ui-modules/blueprint-composer/app/components/providers/blueprint-service.provider.js b/ui-modules/blueprint-composer/app/components/providers/blueprint-service.provider.js
index 7b626e8..38604a3 100644
--- a/ui-modules/blueprint-composer/app/components/providers/blueprint-service.provider.js
+++ b/ui-modules/blueprint-composer/app/components/providers/blueprint-service.provider.js
@@ -538,7 +538,8 @@ function BlueprintService($log, $q, $sce, paletteApi, iconGenerator, dslService)
}
function addUnlistedParameterDefinitions(entity) {
- // copy parameter definitions set on this entity into the miscData aggregated view
+ // copy parameter definitions set on this entity into the miscData aggregated view;
+ // TODO see discussions in PR 112 about whether this is necessary and/or there is a better way
let allParams = entity.miscData.get('parameters') || [];
entity.parameters.forEach((param) => {
if (!allParams.some((e) => e.name === param.name)) {