You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Pedro Santos (JIRA)" <ji...@apache.org> on 2009/12/17 21:20:18 UTC
[jira] Created: (WICKET-2625) WICKET-2478 correction are break
WICKET-2478 correction are break
--------------------------------
Key: WICKET-2625
URL: https://issues.apache.org/jira/browse/WICKET-2625
Project: Wicket
Issue Type: Sub-task
Components: wicket-extensions
Affects Versions: 1.4.4
Reporter: Pedro Santos
By increasing the array before checking with 1 the code will work when user add only one tab to component...
The applied solution break the correction made for the issue WICKET-2478
I propose:
++ if (tabsVisibilityCache == null || tabsVisibilityCache.length != tabs.size())
{
tabsVisibilityCache = new Boolean[tabs.size()];
}
-- if (tabsVisibilityCache.length < tabIndex + 1)
-- {
-- Boolean[] resized = new Boolean[tabIndex + 1];
-- System.arraycopy(tabsVisibilityCache, 0, resized, 0, tabsVisibilityCache.length);
-- tabsVisibilityCache = resized;
-- }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (WICKET-2625) WICKET-2478 correction are break
Posted by "Pedro Santos (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pedro Santos closed WICKET-2625.
--------------------------------
Fix Version/s: 1.4.11
Resolution: Fixed
I test the quickstart at WICKET-2478 with the path at WICKET-2828 and it is working.
> WICKET-2478 correction are break
> --------------------------------
>
> Key: WICKET-2625
> URL: https://issues.apache.org/jira/browse/WICKET-2625
> Project: Wicket
> Issue Type: Sub-task
> Components: wicket-extensions
> Affects Versions: 1.4.4
> Reporter: Pedro Santos
> Fix For: 1.4.11
>
>
> By increasing the array before checking with 1 the code will work when user add only one tab to component...
> The applied solution break the correction made for the issue WICKET-2478
> I propose:
> ++ if (tabsVisibilityCache == null || tabsVisibilityCache.length != tabs.size())
> {
> tabsVisibilityCache = new Boolean[tabs.size()];
> }
> -- if (tabsVisibilityCache.length < tabIndex + 1)
> -- {
> -- Boolean[] resized = new Boolean[tabIndex + 1];
> -- System.arraycopy(tabsVisibilityCache, 0, resized, 0, tabsVisibilityCache.length);
> -- tabsVisibilityCache = resized;
> -- }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2625) WICKET-2478 correction are break
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12793979#action_12793979 ]
Juergen Donnerstag commented on WICKET-2625:
--------------------------------------------
Why does it make sense to cache it anyway? Shouldn't the visibility be much rather a function of the MarkupContainer that implements the tab?
> WICKET-2478 correction are break
> --------------------------------
>
> Key: WICKET-2625
> URL: https://issues.apache.org/jira/browse/WICKET-2625
> Project: Wicket
> Issue Type: Sub-task
> Components: wicket-extensions
> Affects Versions: 1.4.4
> Reporter: Pedro Santos
>
> By increasing the array before checking with 1 the code will work when user add only one tab to component...
> The applied solution break the correction made for the issue WICKET-2478
> I propose:
> ++ if (tabsVisibilityCache == null || tabsVisibilityCache.length != tabs.size())
> {
> tabsVisibilityCache = new Boolean[tabs.size()];
> }
> -- if (tabsVisibilityCache.length < tabIndex + 1)
> -- {
> -- Boolean[] resized = new Boolean[tabIndex + 1];
> -- System.arraycopy(tabsVisibilityCache, 0, resized, 0, tabsVisibilityCache.length);
> -- tabsVisibilityCache = resized;
> -- }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.