You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by keval bhatt <ke...@freestoneinfotech.com> on 2016/05/17 14:20:09 UTC
Re: Review Request 46197: ATLAS-658 : Improve Lineage with Backbone
porting
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46197/
-----------------------------------------------------------
(Updated May 17, 2016, 2:20 p.m.)
Review request for atlas, Erik Bergenholtz, Gautam Borad, Mehul Parikh, Nixon Rodrigues, and Hemanth Yamijala.
Changes
-------
* Tried with your given query and its working fine.
* Removed hardcoded "Table" check for icons.
Bugs: ATLAS-658
https://issues.apache.org/jira/browse/ATLAS-658
Repository: atlas
Description
-------
Improved display of vertices and edges in lineage graph that gets generated.
Diffs (updated)
-----
dashboardv2/public/css/style.css d1d23cc
dashboardv2/public/img/icon-gear-active.png PRE-CREATION
dashboardv2/public/img/icon-table-active.png PRE-CREATION
dashboardv2/public/js/collection/BaseCollection.js 2018019
dashboardv2/public/js/collection/VCommonList.js d9e1f52
dashboardv2/public/js/collection/VSchemaList.js 6a5c9d6
dashboardv2/public/js/collection/VTagList.js 9fa48bf
dashboardv2/public/js/modules/Helpers.js 4deb19b
dashboardv2/public/js/templates/common/TableLayout_tmpl.html 4264035
dashboardv2/public/js/templates/common/modal.html 0f64f5a
dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html 3a8eb44
dashboardv2/public/js/templates/graph/LineageLayoutView_tmpl.html 0c32a48
dashboardv2/public/js/templates/schema/SchemaTableLayoutView_tmpl.html cbc0e8a
dashboardv2/public/js/templates/tag/addTagModalView_tmpl.html acae4e1
dashboardv2/public/js/utils/Overrides.js 3b598e3
dashboardv2/public/js/utils/Utils.js 3892c72
dashboardv2/public/js/views/asset/AssetPageLayoutView.js 6334790
dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 87adec0
dashboardv2/public/js/views/graph/LineageLayoutView.js 973d091
dashboardv2/public/js/views/schema/SchemaLayoutView.js de558a7
dashboardv2/public/js/views/tag/TagLayoutView.js 42791b9
dashboardv2/public/js/views/tag/addTagModalView.js d7e7c67
dashboardv2/public/js/views/tag/createTagsLayoutView.js 5d93eee
Diff: https://reviews.apache.org/r/46197/diff/
Testing
-------
1) mvn tests
2) Loaded the new UI in local sandbox and verified Lineage graph generation with proper vcertices and edges shown based on input and output of API calls.
Thanks,
keval bhatt
Re: Review Request 46197: ATLAS-658 : Improve Lineage with Backbone
porting
Posted by Hemanth Yamijala <yh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46197/#review133867
-----------------------------------------------------------
Ship it!
Ship It!
- Hemanth Yamijala
On May 17, 2016, 2:20 p.m., keval bhatt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46197/
> -----------------------------------------------------------
>
> (Updated May 17, 2016, 2:20 p.m.)
>
>
> Review request for atlas, Erik Bergenholtz, Gautam Borad, Mehul Parikh, Nixon Rodrigues, and Hemanth Yamijala.
>
>
> Bugs: ATLAS-658
> https://issues.apache.org/jira/browse/ATLAS-658
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Improved display of vertices and edges in lineage graph that gets generated.
>
>
> Diffs
> -----
>
> dashboardv2/public/css/style.css d1d23cc
> dashboardv2/public/img/icon-gear-active.png PRE-CREATION
> dashboardv2/public/img/icon-table-active.png PRE-CREATION
> dashboardv2/public/js/collection/BaseCollection.js 2018019
> dashboardv2/public/js/collection/VCommonList.js d9e1f52
> dashboardv2/public/js/collection/VSchemaList.js 6a5c9d6
> dashboardv2/public/js/collection/VTagList.js 9fa48bf
> dashboardv2/public/js/modules/Helpers.js 4deb19b
> dashboardv2/public/js/templates/common/TableLayout_tmpl.html 4264035
> dashboardv2/public/js/templates/common/modal.html 0f64f5a
> dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html 3a8eb44
> dashboardv2/public/js/templates/graph/LineageLayoutView_tmpl.html 0c32a48
> dashboardv2/public/js/templates/schema/SchemaTableLayoutView_tmpl.html cbc0e8a
> dashboardv2/public/js/templates/tag/addTagModalView_tmpl.html acae4e1
> dashboardv2/public/js/utils/Overrides.js 3b598e3
> dashboardv2/public/js/utils/Utils.js 3892c72
> dashboardv2/public/js/views/asset/AssetPageLayoutView.js 6334790
> dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 87adec0
> dashboardv2/public/js/views/graph/LineageLayoutView.js 973d091
> dashboardv2/public/js/views/schema/SchemaLayoutView.js de558a7
> dashboardv2/public/js/views/tag/TagLayoutView.js 42791b9
> dashboardv2/public/js/views/tag/addTagModalView.js d7e7c67
> dashboardv2/public/js/views/tag/createTagsLayoutView.js 5d93eee
>
> Diff: https://reviews.apache.org/r/46197/diff/
>
>
> Testing
> -------
>
> 1) mvn tests
> 2) Loaded the new UI in local sandbox and verified Lineage graph generation with proper vcertices and edges shown based on input and output of API calls.
>
>
> Thanks,
>
> keval bhatt
>
>