You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/03/15 06:33:00 UTC
[jira] [Commented] (FLINK-8771) Upgrade scalastyle to 1.0.0
[ https://issues.apache.org/jira/browse/FLINK-8771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16399978#comment-16399978 ]
ASF GitHub Bot commented on FLINK-8771:
---------------------------------------
GitHub user bowenli86 opened a pull request:
https://github.com/apache/flink/pull/5702
[FLINK-8771] Upgrade scalastyle to 1.0.0
## What is the purpose of the change
Upgrade scalastyle from 0.8.0 to 1.0.0
## Brief change log
- Upgrade scalastyle from 0.8.0 to 1.0.0
- Fixed some license style issues along the way, because scalalstyle 1.0.0 detected those as errors
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
none
## Documentation
none
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bowenli86/flink FLINK-8771
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5702.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5702
----
commit 97160a70ae64e90cc101512ab0fb4c08ba79d924
Author: Bowen Li <bo...@...>
Date: 2018-03-15T00:26:18Z
[FLINK-8771] Upgrade scalastyle to 1.0.0
----
> Upgrade scalastyle to 1.0.0
> ---------------------------
>
> Key: FLINK-8771
> URL: https://issues.apache.org/jira/browse/FLINK-8771
> Project: Flink
> Issue Type: Improvement
> Components: Build System
> Reporter: Ted Yu
> Assignee: Bowen Li
> Priority: Major
>
> scalastyle 1.0.0 fixes issue with import order, explicit type for public methods, line length limitation and comment validation.
> We should upgrade to scalastyle 1.0.0
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)