[GitHub] [iceberg] pvary commented on a diff in pull request #4946: API: Support registering filesystem tables to metastore based catalogs

[GitBox <gi...@apache.org>]

pvary commented on code in PR #4946:
URL: https://github.com/apache/iceberg/pull/4946#discussion_r895513485


##########
core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java:
##########
@@ -334,6 +334,12 @@ private String newTableMetadataFilePath(TableMetadata meta, int newVersion) {
   private static int parseVersion(String metadataLocation) {
     int versionStart = metadataLocation.lastIndexOf('/') + 1; // if '/' isn't found, this will be 0
     int versionEnd = metadataLocation.indexOf('-', versionStart);
+    if (versionEnd < 0) {
+      // As per the spec, metastore tables and filesystem tables
+      // will have different representation for metadata file names.
+      LOG.warn("Found filesystem table's metadata : {}", metadataLocation);
+      return -1;
+    }

Review Comment:
   nit: we usually leave a new line after blocks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org