You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "englefly (via GitHub)" <gi...@apache.org> on 2023/06/01 12:45:27 UTC
[GitHub] [doris] englefly opened a new pull request, #20341: [fix](nereids) fix bug: ColumnStatistics.avgSizeByte = 0
englefly opened a new pull request, #20341:
URL: https://github.com/apache/doris/pull/20341
## Proposed changes
it takes lot of effort to compute the avgSizeByte for col stats.
we use schema information to avoid compute actual average size.
Issue Number: close #xxx
<--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] englefly commented on pull request #20341: [fix](nereids) fix bug: ColumnStatistics.avgSizeByte = 0
Posted by "englefly (via GitHub)" <gi...@apache.org>.
englefly commented on PR #20341:
URL: https://github.com/apache/doris/pull/20341#issuecomment-1575962905
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] englefly commented on pull request #20341: [fix](nereids) fix bug: ColumnStatistics.avgSizeByte = 0
Posted by "englefly (via GitHub)" <gi...@apache.org>.
englefly commented on PR #20341:
URL: https://github.com/apache/doris/pull/20341#issuecomment-1573003760
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20341: [fix](nereids) fix bug: ColumnStatistics.avgSizeByte = 0
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20341:
URL: https://github.com/apache/doris/pull/20341#issuecomment-1572014517
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] englefly commented on a diff in pull request #20341: [fix](nereids) fix bug: ColumnStatistics.avgSizeByte = 0
Posted by "englefly (via GitHub)" <gi...@apache.org>.
englefly commented on code in PR #20341:
URL: https://github.com/apache/doris/pull/20341#discussion_r1213824173
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/stats/StatsCalculator.java:
##########
@@ -551,6 +551,11 @@ private Statistics computeScan(Scan scan) {
throw new RuntimeException(String.format("Invalid slot: %s", slotReference.getExprId()));
}
ColumnStatistic cache = Config.enable_stats ? getColumnStatistic(table, colName) : ColumnStatistic.UNKNOWN;
+ if (cache.avgSizeByte <= 0) {
Review Comment:
The avgSizeByte means its size defined in schema. Even for UNKNOWN, its avgSizeByte is available.
And this size is useful when we compute the cost of data transfer, given a schema defined size is better than Zero.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20341: [fix](nereids) fix bug: ColumnStatistics.avgSizeByte = 0
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20341:
URL: https://github.com/apache/doris/pull/20341#issuecomment-1573003429
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #20341: [fix](nereids) fix bug: ColumnStatistics.avgSizeByte = 0
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on code in PR #20341:
URL: https://github.com/apache/doris/pull/20341#discussion_r1213326960
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/stats/StatsCalculator.java:
##########
@@ -551,6 +551,11 @@ private Statistics computeScan(Scan scan) {
throw new RuntimeException(String.format("Invalid slot: %s", slotReference.getExprId()));
}
ColumnStatistic cache = Config.enable_stats ? getColumnStatistic(table, colName) : ColumnStatistic.UNKNOWN;
+ if (cache.avgSizeByte <= 0) {
Review Comment:
```suggestion
if (cache != ColumnStatistic.UNKNOWN && cache.avgSizeByte <= 0) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow merged pull request #20341: [fix](nereids) avg size of column stats always be 0
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow merged PR #20341:
URL: https://github.com/apache/doris/pull/20341
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] englefly commented on pull request #20341: [fix](nereids) fix bug: ColumnStatistics.avgSizeByte = 0
Posted by "englefly (via GitHub)" <gi...@apache.org>.
englefly commented on PR #20341:
URL: https://github.com/apache/doris/pull/20341#issuecomment-1575919272
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org