You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/06/08 18:27:46 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3869: syslog: Added separator in file logs.

xiaoxiang781216 commented on a change in pull request #3869:
URL: https://github.com/apache/incubator-nuttx/pull/3869#discussion_r647695275



##########
File path: drivers/syslog/syslog_filechannel.c
##########
@@ -60,6 +60,23 @@ FAR static struct syslog_channel_s *g_syslog_file_channel;
  * Private Functions
  ****************************************************************************/
 
+#ifdef CONFIG_SYSLOG_FILE_SEPARATE
+static void log_separate(FAR const char *log_file)
+{
+  int fd;
+
+  fd = open(log_file, O_WRONLY);

Review comment:
       change to file_open/file_write/file_close




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org