You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/05/21 23:28:39 UTC

[GitHub] [activemq-artemis] zekeoptimo opened a new pull request #3146: ARTEMIS-2776 Improve Dockerfiles

zekeoptimo opened a new pull request #3146:
URL: https://github.com/apache/activemq-artemis/pull/3146


   Fixes the Dockerfiles handling of ANONYMOUS_LOGIN and adds an
   EXTRA_ARGS environment variable to allow specifying extra arguments
   separate from the username, password and anonymous login options.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] zekeoptimo commented on pull request #3146: ARTEMIS-2776 Improve Dockerfiles

Posted by GitBox <gi...@apache.org>.
zekeoptimo commented on pull request #3146:
URL: https://github.com/apache/activemq-artemis/pull/3146#issuecomment-632397245


   This solves a couple of problems: 
   
   1) The ANONYMOUS_LOGIN environment variable was not being used, and in testing I found that it would default to allow anonymous logging no matter what (due to the --silent command being forced to make a choice)
   
   2) I believe this will make configuration easier, particular in an environment where usernames and/or passwords are kept as secrets. Allowing the ability to specify other parameters via EXTRA_ARGS allows specifying usernames and passwords separately from other configuration.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] asfgit closed pull request #3146: ARTEMIS-2776 Improve Dockerfiles

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3146:
URL: https://github.com/apache/activemq-artemis/pull/3146


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org