[GitHub] [spark] gatorsmile commented on a change in pull request #26317: [SPARK-29628][SQL] Forcibly create a temporary view in CREATE VIEW if referencing a temporary view

[GitBox <gi...@apache.org>]

gatorsmile commented on a change in pull request #26317: [SPARK-29628][SQL] Forcibly create a temporary view in CREATE VIEW if referencing a temporary view
URL: https://github.com/apache/spark/pull/26317#discussion_r352377240
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala
 ##########
 @@ -192,12 +198,20 @@ case class CreateViewCommand(
       // package (e.g., HiveGenericUDF).
       def verify(child: LogicalPlan) {
         child.collect {
-          // Disallow creating permanent views based on temporary views.
+          // Permanent views will be created as temporary view if based on temporary view.
           case UnresolvedRelation(AsTableIdentifier(ident))
             if sparkSession.sessionState.catalog.isTemporaryTable(ident) =>
-            // temporary views are only stored in the session catalog
-            throw new AnalysisException(s"Not allowed to create a permanent view $name by " +
-              s"referencing a temporary view $ident")
+            // Temporary views are only stored in the session catalog
+            if (sparkSession.sqlContext.conf.usePostgreSQLDialect) {
 
 Review comment:
   We are removing this dialect as we discussed in the mailing list. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org