You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Fredy Wijaya (Code Review)" <ge...@cloudera.org> on 2019/05/09 18:47:40 UTC
[Impala-ASF-CR] IMPALA-8530: Return more user friendly error messages on unsupported SQL
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13295
Change subject: IMPALA-8530: Return more user friendly error messages on unsupported SQL
......................................................................
IMPALA-8530: Return more user friendly error messages on unsupported SQL
This patch updates the error messages to return more friendly error
messages for the unsupported SQL statements when running with Sentry or
Ranger to improve user experience. This patch tries to differentiate
between UnsupportedOperationException, which is an internal exception to
indicate a programming error vs UnsupportedFeatureException, which is
an exception that will be exposed to the users to indicate that a
feature is not supported.
Testing:
- Added tests for unsupported SQL
- Ran FE tests
- Ran E2E authorization tests
Change-Id: Icf08ee9e1a83d7597811b1c8585aee5872d0baaf
---
M fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java
M fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java
M fe/src/main/java/org/apache/impala/authorization/sentry/SentryCatalogdAuthorizationManager.java
M fe/src/main/java/org/apache/impala/authorization/sentry/SentryImpaladAuthorizationManager.java
M tests/authorization/test_ranger.py
M tests/authorization/test_sentry.py
6 files changed, 78 insertions(+), 32 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/95/13295/2
--
To view, visit http://gerrit.cloudera.org:8080/13295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icf08ee9e1a83d7597811b1c8585aee5872d0baaf
Gerrit-Change-Number: 13295
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
[Impala-ASF-CR] IMPALA-8530: Return more user friendly error messages on unsupported SQL
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13295 )
Change subject: IMPALA-8530: Return more user friendly error messages on unsupported SQL
......................................................................
IMPALA-8530: Return more user friendly error messages on unsupported SQL
This patch updates the error messages to return more friendly error
messages for the unsupported SQL statements when running with Sentry or
Ranger to improve user experience. This patch tries to differentiate
between UnsupportedOperationException, which is an internal exception to
indicate a programming error vs UnsupportedFeatureException, which is
an exception that will be exposed to the users to indicate that a
feature is not supported.
Testing:
- Added tests for unsupported SQL
- Ran FE tests
- Ran E2E authorization tests
Change-Id: Icf08ee9e1a83d7597811b1c8585aee5872d0baaf
Reviewed-on: http://gerrit.cloudera.org:8080/13295
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java
M fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java
M fe/src/main/java/org/apache/impala/authorization/sentry/SentryCatalogdAuthorizationManager.java
M fe/src/main/java/org/apache/impala/authorization/sentry/SentryImpaladAuthorizationManager.java
M fe/src/main/java/org/apache/impala/service/Frontend.java
M tests/authorization/test_ranger.py
M tests/authorization/test_sentry.py
7 files changed, 84 insertions(+), 36 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/13295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Icf08ee9e1a83d7597811b1c8585aee5872d0baaf
Gerrit-Change-Number: 13295
Gerrit-PatchSet: 6
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[Impala-ASF-CR] IMPALA-8530: Return more user friendly error messages on unsupported SQL
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13295 )
Change subject: IMPALA-8530: Return more user friendly error messages on unsupported SQL
......................................................................
Patch Set 3: Code-Review+1
Rebased and carry +1
--
To view, visit http://gerrit.cloudera.org:8080/13295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf08ee9e1a83d7597811b1c8585aee5872d0baaf
Gerrit-Change-Number: 13295
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 11 May 2019 01:42:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8530: Return more user friendly error messages on unsupported SQL
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13295 )
Change subject: IMPALA-8530: Return more user friendly error messages on unsupported SQL
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/3198/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf08ee9e1a83d7597811b1c8585aee5872d0baaf
Gerrit-Change-Number: 13295
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 13 May 2019 18:14:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8530: Return more user friendly error messages on unsupported SQL
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13295 )
Change subject: IMPALA-8530: Return more user friendly error messages on unsupported SQL
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/3189/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf08ee9e1a83d7597811b1c8585aee5872d0baaf
Gerrit-Change-Number: 13295
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Sat, 11 May 2019 02:04:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8530: Return more user friendly error messages on unsupported SQL
Posted by "Austin Nobis (Code Review)" <ge...@cloudera.org>.
Austin Nobis has posted comments on this change. ( http://gerrit.cloudera.org:8080/13295 )
Change subject: IMPALA-8530: Return more user friendly error messages on unsupported SQL
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/13295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf08ee9e1a83d7597811b1c8585aee5872d0baaf
Gerrit-Change-Number: 13295
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 10 May 2019 19:49:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8530: Return more user friendly error messages on unsupported SQL
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13295 )
Change subject: IMPALA-8530: Return more user friendly error messages on unsupported SQL
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4237/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/13295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf08ee9e1a83d7597811b1c8585aee5872d0baaf
Gerrit-Change-Number: 13295
Gerrit-PatchSet: 5
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 13 May 2019 17:16:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8530: Return more user friendly error messages on unsupported SQL
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/13295 )
Change subject: IMPALA-8530: Return more user friendly error messages on unsupported SQL
......................................................................
IMPALA-8530: Return more user friendly error messages on unsupported SQL
This patch updates the error messages to return more friendly error
messages for the unsupported SQL statements when running with Sentry or
Ranger to improve user experience. This patch tries to differentiate
between UnsupportedOperationException, which is an internal exception to
indicate a programming error vs UnsupportedFeatureException, which is
an exception that will be exposed to the users to indicate that a
feature is not supported.
Testing:
- Added tests for unsupported SQL
- Ran FE tests
- Ran E2E authorization tests
Change-Id: Icf08ee9e1a83d7597811b1c8585aee5872d0baaf
---
M fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java
M fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java
M fe/src/main/java/org/apache/impala/authorization/sentry/SentryCatalogdAuthorizationManager.java
M fe/src/main/java/org/apache/impala/authorization/sentry/SentryImpaladAuthorizationManager.java
M fe/src/main/java/org/apache/impala/service/Frontend.java
M tests/authorization/test_ranger.py
M tests/authorization/test_sentry.py
7 files changed, 84 insertions(+), 36 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/95/13295/4
--
To view, visit http://gerrit.cloudera.org:8080/13295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icf08ee9e1a83d7597811b1c8585aee5872d0baaf
Gerrit-Change-Number: 13295
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[Impala-ASF-CR] IMPALA-8530: Return more user friendly error messages on unsupported SQL
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13295 )
Change subject: IMPALA-8530: Return more user friendly error messages on unsupported SQL
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
Carry Todd's +2.
http://gerrit.cloudera.org:8080/#/c/13295/3/fe/src/main/java/org/apache/impala/authorization/sentry/SentryImpaladAuthorizationManager.java
File fe/src/main/java/org/apache/impala/authorization/sentry/SentryImpaladAuthorizationManager.java:
http://gerrit.cloudera.org:8080/#/c/13295/3/fe/src/main/java/org/apache/impala/authorization/sentry/SentryImpaladAuthorizationManager.java@228
PS3, Line 228: case GROUP:
> worth putting this in an explicit 'case GROUP' in case we add another enum
Being explicit is good. Done.
--
To view, visit http://gerrit.cloudera.org:8080/13295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf08ee9e1a83d7597811b1c8585aee5872d0baaf
Gerrit-Change-Number: 13295
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 13 May 2019 17:16:33 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8530: Return more user friendly error messages on unsupported SQL
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13295 )
Change subject: IMPALA-8530: Return more user friendly error messages on unsupported SQL
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
small nit
http://gerrit.cloudera.org:8080/#/c/13295/3/fe/src/main/java/org/apache/impala/authorization/sentry/SentryImpaladAuthorizationManager.java
File fe/src/main/java/org/apache/impala/authorization/sentry/SentryImpaladAuthorizationManager.java:
http://gerrit.cloudera.org:8080/#/c/13295/3/fe/src/main/java/org/apache/impala/authorization/sentry/SentryImpaladAuthorizationManager.java@228
PS3, Line 228: default:
worth putting this in an explicit 'case GROUP' in case we add another enum value later? Or use params.getPrincipal_type().toString() instead of 'GROUP'
--
To view, visit http://gerrit.cloudera.org:8080/13295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf08ee9e1a83d7597811b1c8585aee5872d0baaf
Gerrit-Change-Number: 13295
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 13 May 2019 17:11:16 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8530: Return more user friendly error messages on unsupported SQL
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13295 )
Change subject: IMPALA-8530: Return more user friendly error messages on unsupported SQL
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/3153/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf08ee9e1a83d7597811b1c8585aee5872d0baaf
Gerrit-Change-Number: 13295
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 09 May 2019 19:49:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8530: Return more user friendly error messages on unsupported SQL
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/13295 )
Change subject: IMPALA-8530: Return more user friendly error messages on unsupported SQL
......................................................................
IMPALA-8530: Return more user friendly error messages on unsupported SQL
This patch updates the error messages to return more friendly error
messages for the unsupported SQL statements when running with Sentry or
Ranger to improve user experience. This patch tries to differentiate
between UnsupportedOperationException, which is an internal exception to
indicate a programming error vs UnsupportedFeatureException, which is
an exception that will be exposed to the users to indicate that a
feature is not supported.
Testing:
- Added tests for unsupported SQL
- Ran FE tests
- Ran E2E authorization tests
Change-Id: Icf08ee9e1a83d7597811b1c8585aee5872d0baaf
---
M fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java
M fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java
M fe/src/main/java/org/apache/impala/authorization/sentry/SentryCatalogdAuthorizationManager.java
M fe/src/main/java/org/apache/impala/authorization/sentry/SentryImpaladAuthorizationManager.java
M fe/src/main/java/org/apache/impala/service/Frontend.java
M tests/authorization/test_ranger.py
M tests/authorization/test_sentry.py
7 files changed, 83 insertions(+), 38 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/95/13295/3
--
To view, visit http://gerrit.cloudera.org:8080/13295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icf08ee9e1a83d7597811b1c8585aee5872d0baaf
Gerrit-Change-Number: 13295
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-8530: Return more user friendly error messages on unsupported SQL
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13295 )
Change subject: IMPALA-8530: Return more user friendly error messages on unsupported SQL
......................................................................
Patch Set 2:
This CR will depend on this clean-up CR: https://gerrit.cloudera.org/c/13284/
--
To view, visit http://gerrit.cloudera.org:8080/13295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf08ee9e1a83d7597811b1c8585aee5872d0baaf
Gerrit-Change-Number: 13295
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 09 May 2019 18:48:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8530: Return more user friendly error messages on unsupported SQL
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13295 )
Change subject: IMPALA-8530: Return more user friendly error messages on unsupported SQL
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/13295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf08ee9e1a83d7597811b1c8585aee5872d0baaf
Gerrit-Change-Number: 13295
Gerrit-PatchSet: 5
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 13 May 2019 22:53:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8530: Return more user friendly error messages on unsupported SQL
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13295 )
Change subject: IMPALA-8530: Return more user friendly error messages on unsupported SQL
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf08ee9e1a83d7597811b1c8585aee5872d0baaf
Gerrit-Change-Number: 13295
Gerrit-PatchSet: 5
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 13 May 2019 17:16:52 +0000
Gerrit-HasComments: No