[GitHub] [tvm] jwfromm commented on a diff in pull request #12124: [Relay][Op] Trilu operator implementation

[GitBox <gi...@apache.org>]

jwfromm commented on code in PR #12124:
URL: https://github.com/apache/tvm/pull/12124#discussion_r930487887


##########
tests/python/frontend/onnx/test_forward.py:
##########
@@ -5241,23 +5241,7 @@ def verify_eyelike(indata, dynamic=False):
     "test_training_dropout_mask",
     "test_training_dropout_zero_ratio",
     "test_training_dropout_zero_ratio_mask",
-    "test_tril",
-    "test_tril_pos",
-    "test_tril_square",
-    "test_tril_square_neg",
-    "test_tril_neg",
-    "test_tril_one_row_neg",
-    "test_tril_out_neg",
-    "test_tril_out_pos",
     "test_tril_zero",

Review Comment:
   It actually works on llvm and cuda. I was testing on my macbook and it seems like the metal backend in general doesnt support empty tensors. I think for CI we could add these cases.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org