You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by dh...@apache.org on 2022/04/16 17:23:58 UTC

[arrow-rs] branch master updated: Use littleendian arrow files for projection_should_work (#1573)

This is an automated email from the ASF dual-hosted git repository.

dheres pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow-rs.git


The following commit(s) were added to refs/heads/master by this push:
     new 6bb6ed0a9 Use littleendian arrow files for projection_should_work (#1573)
6bb6ed0a9 is described below

commit 6bb6ed0a94361319fd393d45ed45f29b4e87685a
Author: Liang-Chi Hsieh <vi...@gmail.com>
AuthorDate: Sat Apr 16 10:23:53 2022 -0700

    Use littleendian arrow files for projection_should_work (#1573)
---
 arrow/src/ipc/reader.rs | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/arrow/src/ipc/reader.rs b/arrow/src/ipc/reader.rs
index fe10fe548..143fa929d 100644
--- a/arrow/src/ipc/reader.rs
+++ b/arrow/src/ipc/reader.rs
@@ -1108,15 +1108,13 @@ mod tests {
     }
 
     #[test]
-    // https://github.com/apache/arrow-rs/issues/1548
-    #[cfg(not(feature = "force_validate"))]
     fn projection_should_work() {
         // complementary to the previous test
         let testdata = crate::util::test_util::arrow_test_data();
         let paths = vec![
             "generated_interval",
             "generated_datetime",
-            // "generated_map", Err: Last offset 872415232 of Utf8 is larger than values length 52 (https://github.com/apache/arrow-rs/issues/859)
+            "generated_map",
             "generated_nested",
             "generated_null_trivial",
             "generated_null",
@@ -1125,8 +1123,11 @@ mod tests {
             "generated_primitive",
         ];
         paths.iter().for_each(|path| {
+            // We must use littleendian files here.
+            // The offsets are not translated for big-endian files
+            // https://github.com/apache/arrow-rs/issues/859
             let file = File::open(format!(
-                "{}/arrow-ipc-stream/integration/1.0.0-bigendian/{}.arrow_file",
+                "{}/arrow-ipc-stream/integration/1.0.0-littleendian/{}.arrow_file",
                 testdata, path
             ))
             .unwrap();