You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by sanjeev n <sa...@citrix.com> on 2014/07/17 11:22:09 UTC
Review Request 23609: Signature changes to delete method in VirtualMachine
class in base.py
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23609/
-----------------------------------------------------------
Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri.
Repository: cloudstack-git
Description
-------
destroyVirtualMachine API takes only one parameter (id-virtualmachine id) till CS 4.2. In 4.3 we have added expunge parameter to expunge the vm at the destroy time instead of waiting for expunge interval.
Made changes to delete method to accept additional parameters.
Diffs
-----
tools/marvin/marvin/lib/base.py e9d5bb4
Diff: https://reviews.apache.org/r/23609/diff/
Testing
-------
yes
Thanks,
sanjeev n
Re: Review Request 23609: Signature changes to delete method in
VirtualMachine class in base.py
Posted by Santhosh Edukulla <sa...@citrix.com>.
> On July 21, 2014, 2:36 p.m., Santhosh Edukulla wrote:
> > Ship It!
>
> Santhosh Edukulla wrote:
> please add bugid.
88f3517..4596ae9 master -> master
- Santhosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23609/#review48224
-----------------------------------------------------------
On July 17, 2014, 9:22 a.m., sanjeev n wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23609/
> -----------------------------------------------------------
>
> (Updated July 17, 2014, 9:22 a.m.)
>
>
> Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> destroyVirtualMachine API takes only one parameter (id-virtualmachine id) till CS 4.2. In 4.3 we have added expunge parameter to expunge the vm at the destroy time instead of waiting for expunge interval.
> Made changes to delete method to accept additional parameters.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/lib/base.py e9d5bb4
>
> Diff: https://reviews.apache.org/r/23609/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> sanjeev n
>
>
Re: Review Request 23609: Signature changes to delete method in
VirtualMachine class in base.py
Posted by Santhosh Edukulla <sa...@citrix.com>.
> On July 21, 2014, 2:36 p.m., Santhosh Edukulla wrote:
> > Ship It!
please add bugid.
- Santhosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23609/#review48224
-----------------------------------------------------------
On July 17, 2014, 9:22 a.m., sanjeev n wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23609/
> -----------------------------------------------------------
>
> (Updated July 17, 2014, 9:22 a.m.)
>
>
> Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> destroyVirtualMachine API takes only one parameter (id-virtualmachine id) till CS 4.2. In 4.3 we have added expunge parameter to expunge the vm at the destroy time instead of waiting for expunge interval.
> Made changes to delete method to accept additional parameters.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/lib/base.py e9d5bb4
>
> Diff: https://reviews.apache.org/r/23609/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> sanjeev n
>
>
Re: Review Request 23609: Signature changes to delete method in
VirtualMachine class in base.py
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23609/#review48224
-----------------------------------------------------------
Ship it!
Ship It!
- Santhosh Edukulla
On July 17, 2014, 9:22 a.m., sanjeev n wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23609/
> -----------------------------------------------------------
>
> (Updated July 17, 2014, 9:22 a.m.)
>
>
> Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> destroyVirtualMachine API takes only one parameter (id-virtualmachine id) till CS 4.2. In 4.3 we have added expunge parameter to expunge the vm at the destroy time instead of waiting for expunge interval.
> Made changes to delete method to accept additional parameters.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/lib/base.py e9d5bb4
>
> Diff: https://reviews.apache.org/r/23609/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> sanjeev n
>
>