You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2021/03/18 01:08:43 UTC

[kudu-CR] [security] move SslTypeTraits::kFreeFunc to openssl util.h

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17196


Change subject: [security] move SslTypeTraits<BIO>::kFreeFunc to openssl_util.h
......................................................................

[security] move SslTypeTraits<BIO>::kFreeFunc to openssl_util.h

This patch moves SslTypeTraits<BIO>::kFreeFunc definition from the
openssl_util_bio.h to openssl_util.h header file.  The rationale for
this update is that ssl_make_unique(BIO_new(...)) construct can be
used separately from utility functions defined in openssl_util_bio.h,
exactly like it's done in a follow-up patch.  With that, inclusion of
openssl_util_bio.h isn't necessary once openssl_util.h is already
included.

Change-Id: I04ac09fbd79abda8c07491f4fe3bdbcac0af07ca
---
M src/kudu/security/openssl_util.h
M src/kudu/security/openssl_util_bio.h
2 files changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/17196/1
-- 
To view, visit http://gerrit.cloudera.org:8080/17196
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I04ac09fbd79abda8c07491f4fe3bdbcac0af07ca
Gerrit-Change-Number: 17196
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>

[kudu-CR] [security] move SslTypeTraits::kFreeFunc to openssl util.h

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17196 )

Change subject: [security] move SslTypeTraits<BIO>::kFreeFunc to openssl_util.h
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/17196
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04ac09fbd79abda8c07491f4fe3bdbcac0af07ca
Gerrit-Change-Number: 17196
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 18 Mar 2021 13:26:00 +0000
Gerrit-HasComments: No

[kudu-CR] [security] move SslTypeTraits::kFreeFunc to openssl util.h

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17196 )

Change subject: [security] move SslTypeTraits<BIO>::kFreeFunc to openssl_util.h
......................................................................

[security] move SslTypeTraits<BIO>::kFreeFunc to openssl_util.h

This patch moves SslTypeTraits<BIO>::kFreeFunc definition from the
openssl_util_bio.h to openssl_util.h header file.  The rationale for
this update is that ssl_make_unique(BIO_new(...)) construct can be
used separately from utility functions defined in openssl_util_bio.h,
exactly like it's done in a follow-up patch.  With that, inclusion of
openssl_util_bio.h isn't necessary once openssl_util.h is already
included.

Change-Id: I04ac09fbd79abda8c07491f4fe3bdbcac0af07ca
Reviewed-on: http://gerrit.cloudera.org:8080/17196
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
---
M src/kudu/security/openssl_util.h
M src/kudu/security/openssl_util_bio.h
2 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Grant Henke: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/17196
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I04ac09fbd79abda8c07491f4fe3bdbcac0af07ca
Gerrit-Change-Number: 17196
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)