You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Eduardo Ponce (Jira)" <ji...@apache.org> on 2021/09/13 05:27:00 UTC

[jira] [Updated] (ARROW-13937) [C++][Compute] Add explicit output values to sign function and fix unary type checks

     [ https://issues.apache.org/jira/browse/ARROW-13937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eduardo Ponce updated ARROW-13937:
----------------------------------
    Summary: [C++][Compute] Add explicit output values to sign function and fix unary type checks  (was: [C++][Compute] Add explicit output values to sign function for unsigned inputs)

> [C++][Compute] Add explicit output values to sign function and fix unary type checks
> ------------------------------------------------------------------------------------
>
>                 Key: ARROW-13937
>                 URL: https://issues.apache.org/jira/browse/ARROW-13937
>             Project: Apache Arrow
>          Issue Type: Improvement
>            Reporter: Eduardo Ponce
>            Assignee: Eduardo Ponce
>            Priority: Trivial
>              Labels: pull-request-available
>             Fix For: 6.0.0
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The *sign* function implementation for unsigned integers returns the result of a boolean expression because when casted to an integer it corresponds to the expected value (0 or 1). To make the function more clear, we should be explicit with the return values similar to the other *sign* kernels.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)