[GitHub] [airflow] jens-scheffler-bosch opened a new pull request, #32456: Bugfix, prevent force of unpause on trigger DAG

["jens-scheffler-bosch (via GitHub)" <gi...@apache.org>]

jens-scheffler-bosch opened a new pull request, #32456:
URL: https://github.com/apache/airflow/pull/32456

   ### Apache Airflow version
   
   main (development) (not released)
   
   ### What happened
   
   This PR fixes a new bug introduced when finalizing AIP-50 and adjusting the trigger button behavior: Irrespective of the flag to unpause a DAG when using the Trigger UI, calling always un-pauses.
   
   ### What you think should happen instead
   
   Like advertised in the UI it should only be un-paused if the user selects so.
   
   ### How to reproduce
   
   * Start Airflow, open the UI, use a *disabled* DAG with parameters. Click on the trigger UI
   * Disable the "unpause when paused" switch and trigger. Un-pause will be made even if not desired
   
   Root cause: The unpause flag was added into the trigger URL and irrespective of the form value the URL parameter overrules the form setting.
   
   ### Operating System
   
   Ubuntu 20.04 / Breeze Dev setup in Py 3.8 Container
   
   ### Versions of Apache Airflow Providers
   
   No specific setup, execution in Breeze from latest main
   
   ### Deployment
   
   Other
   
   ### Deployment details
   
   Development setup via `breeze start-airflow...`
   Python 3.8
   Postgres
   Celery worker
   
   ### Anything else
   
   To improve visibility I added a flash() message as a reminder that unpause is needed. Removed the unpause URL parameter.
   
   With this PR the behavior changes as follows:
   * If DAG has no parameters and user triggers (w/o) form: A flash message will be shown if DAG is un-paused implicitly/automatically
   * If DAG has parameters and user switches off the "Un-pause" button a warning will be displayed that DAG is paused.
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] bbovenzi merged pull request #32456: Bugfix, prevent force of unpause on trigger DAG

["bbovenzi (via GitHub)" <gi...@apache.org>]

bbovenzi merged PR #32456:
URL: https://github.com/apache/airflow/pull/32456


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org