[GitHub] WillemJiang commented on a change in pull request #120: SCB-234 fail fast at SagaStart if all alpha clusters are down

[GitBox <gi...@apache.org>]

WillemJiang commented on a change in pull request #120: SCB-234 fail fast at SagaStart if all alpha clusters are down
URL: https://github.com/apache/incubator-servicecomb-saga/pull/120#discussion_r161537114
 
 

 ##########
 File path: omega/omega-connector/omega-connector-grpc/src/main/java/org/apache/servicecomb/saga/omega/connector/grpc/LoadBalancedClusterMessageSender.java
 ##########
 @@ -150,13 +155,15 @@ private MessageSender fastestSender() {
         .filter(entry -> entry.getValue() < Long.MAX_VALUE)
         .min(Comparator.comparingLong(Entry::getValue))
         .map(Entry::getKey)
-        .orElse((event -> {
+        .orElse(event -> {
+          clusterStatus.setHealthy(false);
 
 Review comment:
   The clusterStatus check and setting is not atomic.  maybe we should consider to use single thread to send the event message.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services