You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "Vinod Kone (JIRA)" <ji...@apache.org> on 2018/10/08 14:51:00 UTC
[jira] [Commented] (MESOS-9253) Reviewbot is failing when posting a
review
[ https://issues.apache.org/jira/browse/MESOS-9253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641939#comment-16641939 ]
Vinod Kone commented on MESOS-9253:
-----------------------------------
Reviewbot is still failing
{noformat}
10-08-18_14:40:29 - Running /home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py
Checking if review 68929 needs verification
Skipping blocking review 68929
Checking if review 68941 needs verification
Patch never verified, needs verification
Dependent review:
[https://reviews.apache.org/api/review-requests/68929/]
Verifying review 68941
Dependent review:
[https://reviews.apache.org/api/review-requests/68929/]
Applying review 68929
python support/apply-reviews.py -n -r 68929
Posting review: Bad patch!
Reviews applied: [68941, 68929]
Failed command: python support/apply-reviews.py -n -r 68929
Error:
Traceback (most recent call last):
File "support/apply-reviews.py", line 35, in <module>
import urllib.request
ImportError: No module named request
Full log:
[https://builds.apache.org/job/Mesos-Reviewbot/23458/console]
1 review requests need verification
{noformat}
Maybe it's a python 2 vs 3 issue. [~ArmandGrillet] [~andschwa] Can you take a look?
> Reviewbot is failing when posting a review
> ------------------------------------------
>
> Key: MESOS-9253
> URL: https://issues.apache.org/jira/browse/MESOS-9253
> Project: Mesos
> Issue Type: Bug
> Reporter: Vinod Kone
> Priority: Critical
>
> Observed this in CI.
> [https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Reviewbot/23425/console]
>
> {code}
> 09-23-18_02:12:05 - Running /home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py
> Checking if review 68640 needs verification
> Skipping blocking review 68640
> Checking if review 68641 needs verification
> Patch never verified, needs verification
> Dependent review: [https://reviews.apache.org/api/review-requests/68640/]
> Verifying review 68641
> Dependent review: [https://reviews.apache.org/api/review-requests/68640/]
> Applying review 68640
> python support/apply-reviews.py -n -r 68640
> Traceback (most recent call last):
> File "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py", line 156, in verify_review
> apply_reviews(review_request, reviews, handler)
> File "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py", line 120, in apply_reviews
> reviews, handler)
> File "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py", line 124, in apply_reviews
> apply_review(review_request["id"])
> File "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py", line 97, in apply_review
> shell("python support/apply-reviews.py -n -r %s" % review_id)
> File "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py", line 91, in shell
> command, stderr=subprocess.STDOUT, shell=True)
> File "/usr/lib/python3.5/subprocess.py", line 626, in check_output
> **kwargs).stdout
> File "/usr/lib/python3.5/subprocess.py", line 708, in run
> output=stdout, stderr=stderr)
> subprocess.CalledProcessError: Command 'python support/apply-reviews.py -n -r 68640' returned non-zero exit status 1
> During handling of the above exception, another exception occurred:
> Traceback (most recent call last):
> File "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py", line 292, in <module>
> main()
> File "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py", line 286, in main
> verify_review(review_request, handler)
> File "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py", line 217, in verify_review
> output += "\nFull log: "
> TypeError: can't concat bytes to str
> Build step 'Execute shell' marked build as failure
> Sending e-mails to: builds@mesos.apache.org
> Finished: FAILURE
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)