You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/13 19:46:26 UTC
[GitHub] [beam] damccorm opened a new pull request, #21831: Update references to Jira to GH for the Python SDK
damccorm opened a new pull request, #21831:
URL: https://github.com/apache/beam/pull/21831
Part of https://github.com/apache/beam/issues/21686
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #21831: Update references to Jira to GH for the Python SDK
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #21831:
URL: https://github.com/apache/beam/pull/21831#issuecomment-1154361345
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #21831: Update references to Jira to GH for the Python SDK
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on PR #21831:
URL: https://github.com/apache/beam/pull/21831#issuecomment-1155404419
Note you can run `python -m yapf -i <filename>` (from an environment with yapf installed) to have it format a file for you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on a diff in pull request #21831: Update references to Jira to GH for the Python SDK
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on code in PR #21831:
URL: https://github.com/apache/beam/pull/21831#discussion_r897135935
##########
sdks/python/apache_beam/dataframe/frame_base.py:
##########
@@ -415,19 +415,21 @@ def wrapper(*args, **kwargs):
return wrapper
-def not_implemented_method(op, jira='BEAM-9547', base_type=None):
+def not_implemented_method(op, issue='20318', base_type=None):
"""Generate a stub method for ``op`` that simply raises a NotImplementedError.
For internal use only. No backwards compatibility guarantees."""
assert base_type is not None, "base_type must be specified"
+ issue_url = f"https://issues.apache.org/jira/{issue}." if issue.startswith(
+ "BEAM-") else f"https://github.com/apache/beam/issues/{issue}"
Review Comment:
This is fine for now, to be safe, but let's follow up with a change to remove the else and make sure all the BEAM- references are gone (note to self).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #21831: Update references to Jira to GH for the Python SDK
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #21831:
URL: https://github.com/apache/beam/pull/21831#discussion_r897060146
##########
sdks/python/apache_beam/dataframe/frames.py:
##########
@@ -575,12 +575,12 @@ def reset_index(self, level=None, **kwargs):
if level is not None and not isinstance(level, (tuple, list)):
level = [level]
if level is None or len(level) == self._expr.proxy().index.nlevels:
- # TODO(BEAM-12182): Could do distributed re-index with offsets.
+ # TODO(Issue 20859): Could do distributed re-index with offsets.
requires_partition_by = partitionings.Singleton(
reason=(
f"reset_index(level={level!r}) drops the entire index and "
"creates a new one, so it cannot currently be parallelized "
- "(BEAM-12182)."))
+ "(Issue 20859)."))
Review Comment:
I ended up just moving everything to URLs. I think the same logic applies more generally than just in error messages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #21831: Update references to Jira to GH for the Python SDK
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #21831:
URL: https://github.com/apache/beam/pull/21831#issuecomment-1154361346
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on a diff in pull request #21831: Update references to Jira to GH for the Python SDK
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on code in PR #21831:
URL: https://github.com/apache/beam/pull/21831#discussion_r896199855
##########
sdks/python/apache_beam/dataframe/frames.py:
##########
@@ -575,12 +575,12 @@ def reset_index(self, level=None, **kwargs):
if level is not None and not isinstance(level, (tuple, list)):
level = [level]
if level is None or len(level) == self._expr.proxy().index.nlevels:
- # TODO(BEAM-12182): Could do distributed re-index with offsets.
+ # TODO(Issue 20859): Could do distributed re-index with offsets.
requires_partition_by = partitionings.Singleton(
reason=(
f"reset_index(level={level!r}) drops the entire index and "
"creates a new one, so it cannot currently be parallelized "
- "(BEAM-12182)."))
+ "(Issue 20859)."))
Review Comment:
I think a URL would be preferable in the error message for easy discovery. Previously BEAM-12182 could likely be found with a Google search, but "20859" will require the user to construct the URL.
##########
sdks/python/apache_beam/dataframe/frames.py:
##########
@@ -575,12 +575,12 @@ def reset_index(self, level=None, **kwargs):
if level is not None and not isinstance(level, (tuple, list)):
level = [level]
if level is None or len(level) == self._expr.proxy().index.nlevels:
- # TODO(BEAM-12182): Could do distributed re-index with offsets.
+ # TODO(Issue 20859): Could do distributed re-index with offsets.
requires_partition_by = partitionings.Singleton(
reason=(
f"reset_index(level={level!r}) drops the entire index and "
"creates a new one, so it cannot currently be parallelized "
- "(BEAM-12182)."))
+ "(Issue 20859)."))
Review Comment:
I think a URL would be preferable in error messages for easy discovery. Previously BEAM-12182 could likely be found with a Google search, but "20859" will require the user to construct the URL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #21831: Update references to Jira to GH for the Python SDK
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #21831:
URL: https://github.com/apache/beam/pull/21831#issuecomment-1155512025
R: @TheNeuralBit - I think this should be ready!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #21831: Update references to Jira to GH for the Python SDK
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #21831:
URL: https://github.com/apache/beam/pull/21831#issuecomment-1154361352
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #21831: Update references to Jira to GH for the Python SDK
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #21831:
URL: https://github.com/apache/beam/pull/21831#issuecomment-1154361344
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #21831: Update references to Jira to GH for the Python SDK
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #21831:
URL: https://github.com/apache/beam/pull/21831#issuecomment-1155447670
> Note you can run python -m yapf -i <filename> (from an environment with yapf installed) to have it format a file for you
Oh, just seeing this - well I guess I did it the hard way :shrug:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit merged pull request #21831: Update references to Jira to GH for the Python SDK
Posted by GitBox <gi...@apache.org>.
TheNeuralBit merged PR #21831:
URL: https://github.com/apache/beam/pull/21831
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #21831: Update references to Jira to GH for the Python SDK
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #21831:
URL: https://github.com/apache/beam/pull/21831#issuecomment-1154503665
# [Codecov](https://codecov.io/gh/apache/beam/pull/21831?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21831](https://codecov.io/gh/apache/beam/pull/21831?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (00640c6) into [master](https://codecov.io/gh/apache/beam/commit/4c6c969a13165df375edaa96a610bf1787277d65?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4c6c969) will **decrease** coverage by `0.01%`.
> The diff coverage is `62.50%`.
```diff
@@ Coverage Diff @@
## master #21831 +/- ##
==========================================
- Coverage 74.15% 74.13% -0.02%
==========================================
Files 698 698
Lines 92417 92415 -2
==========================================
- Hits 68530 68515 -15
- Misses 22636 22649 +13
Partials 1251 1251
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `83.75% <62.50%> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/21831?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/coders/coder\_impl.py](https://codecov.io/gh/apache/beam/pull/21831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL2NvZGVyX2ltcGwucHk=) | `93.97% <ø> (ø)` | |
| [sdks/python/apache\_beam/coders/row\_coder.py](https://codecov.io/gh/apache/beam/pull/21831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL3Jvd19jb2Rlci5weQ==) | `94.49% <ø> (ø)` | |
| [sdks/python/apache\_beam/dataframe/io.py](https://codecov.io/gh/apache/beam/pull/21831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2lvLnB5) | `88.78% <ø> (ø)` | |
| [...on/apache\_beam/examples/complete/juliaset/setup.py](https://codecov.io/gh/apache/beam/pull/21831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvY29tcGxldGUvanVsaWFzZXQvc2V0dXAucHk=) | `0.00% <ø> (ø)` | |
| [...che\_beam/examples/streaming\_wordcount\_debugging.py](https://codecov.io/gh/apache/beam/pull/21831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvc3RyZWFtaW5nX3dvcmRjb3VudF9kZWJ1Z2dpbmcucHk=) | `92.42% <ø> (ø)` | |
| [sdks/python/apache\_beam/io/external/gcp/pubsub.py](https://codecov.io/gh/apache/beam/pull/21831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZXh0ZXJuYWwvZ2NwL3B1YnN1Yi5weQ==) | `0.00% <ø> (ø)` | |
| [sdks/python/apache\_beam/io/fileio.py](https://codecov.io/gh/apache/beam/pull/21831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZmlsZWlvLnB5) | `96.33% <ø> (ø)` | |
| [sdks/python/apache\_beam/io/gcp/bigquery.py](https://codecov.io/gh/apache/beam/pull/21831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5LnB5) | `70.07% <ø> (ø)` | |
| [...s/python/apache\_beam/io/gcp/bigquery\_file\_loads.py](https://codecov.io/gh/apache/beam/pull/21831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5X2ZpbGVfbG9hZHMucHk=) | `87.70% <ø> (ø)` | |
| [sdks/python/apache\_beam/io/gcp/bigtableio.py](https://codecov.io/gh/apache/beam/pull/21831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3RhYmxlaW8ucHk=) | `74.69% <ø> (ø)` | |
| ... and [61 more](https://codecov.io/gh/apache/beam/pull/21831/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/21831?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/21831?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4c6c969...00640c6](https://codecov.io/gh/apache/beam/pull/21831?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #21831: Update references to Jira to GH for the Python SDK
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #21831:
URL: https://github.com/apache/beam/pull/21831#issuecomment-1154361350
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #21831: Update references to Jira to GH for the Python SDK
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #21831:
URL: https://github.com/apache/beam/pull/21831#discussion_r897140299
##########
sdks/python/apache_beam/dataframe/frame_base.py:
##########
@@ -415,19 +415,21 @@ def wrapper(*args, **kwargs):
return wrapper
-def not_implemented_method(op, jira='BEAM-9547', base_type=None):
+def not_implemented_method(op, issue='20318', base_type=None):
"""Generate a stub method for ``op`` that simply raises a NotImplementedError.
For internal use only. No backwards compatibility guarantees."""
assert base_type is not None, "base_type must be specified"
+ issue_url = f"https://issues.apache.org/jira/{issue}." if issue.startswith(
+ "BEAM-") else f"https://github.com/apache/beam/issues/{issue}"
Review Comment:
That sounds good - I mostly left it because I was only guaranteed to get active issues - ones that have been closed weren't migrated and my tool neither flagged nor changed them.
In theory those should have all been removed when the issue was closed, but my experience would indicate otherwise 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org