Re: [PR] Data, Parquet: Fix UUID ClassCastException when reading Parquet files with UUIDs [iceberg]

["nastra (via GitHub)" <gi...@apache.org>]

nastra commented on code in PR #14027:
URL: https://github.com/apache/iceberg/pull/14027#discussion_r2397968951


##########
data/src/test/java/org/apache/iceberg/data/TestMetricsRowGroupFilter.java:
##########
@@ -211,6 +218,9 @@ public void createOrcInputFile() throws IOException {
         structNotNull.setField("_int_field", INT_MIN_VALUE + i);
         record.setField("_struct_not_null", structNotNull); // struct with int
 
+        record.setField(
+            "_uuid_col", (i % 3 == 0) ? UUID_WITH_ZEROS : (i % 3 == 1) ? UUID_WITH_ONES : null);

Review Comment:
   I think it comes down to also testing other expressions. See my other [comment](https://github.com/apache/iceberg/pull/14027#discussion_r2381725749) on this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org