You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/12/06 01:08:05 UTC
[GitHub] [kafka] anatasiavela opened a new pull request, #12957: MINOR: Fix flaky testClientDisconnectionUpdatesRequestMetrics() (#11987)
anatasiavela opened a new pull request, #12957:
URL: https://github.com/apache/kafka/pull/12957
Cherry-pick of [ae45c59](https://github.com/apache/kafka/commit/ae45c59e61c34fcf1abb5d4731a99d400d2c79be).
This PR fixes the flaky SocketServerTest.testClientDisconnectionUpdatesRequestMetrics() test. When a response is sent, the request metrics get updated. But if the metrics get updated before expectedTotalTimeCount is defined, the expected count gets defined with an inaccurate value.
It looks like the order was accidentally swapped in this commit https://github.com/apache/kafka/commit/16d36f1674f4867b4dc498464df20a0e8e18eb3f.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jolshan merged pull request #12957: MINOR: Fix flaky testClientDisconnectionUpdatesRequestMetrics() (#11987)
Posted by "jolshan (via GitHub)" <gi...@apache.org>.
jolshan merged PR #12957:
URL: https://github.com/apache/kafka/pull/12957
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jolshan commented on pull request #12957: MINOR: Fix flaky testClientDisconnectionUpdatesRequestMetrics() (#11987)
Posted by "jolshan (via GitHub)" <gi...@apache.org>.
jolshan commented on PR #12957:
URL: https://github.com/apache/kafka/pull/12957#issuecomment-1430506039
Is this an issue only on 3.2?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org