You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Todd Lipcon (JIRA)" <ji...@apache.org> on 2009/11/06 20:52:32 UTC
[jira] Created: (THRIFT-622) Update NOTICE to call out all
non-Apache2 contributions
Update NOTICE to call out all non-Apache2 contributions
-------------------------------------------------------
Key: THRIFT-622
URL: https://issues.apache.org/jira/browse/THRIFT-622
Project: Thrift
Issue Type: Task
Affects Versions: 0.1
Reporter: Todd Lipcon
Assignee: Todd Lipcon
Attachments: thrift-622.txt
I spoke with Joe Schaefer at ApacheCon the other day, and I believe these are the necessary changes to be kosher for a release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-622) Get Thrift into releasable form
(eliminate dependencies, tidy licenses, etc)
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12776283#action_12776283 ]
David Reiss commented on THRIFT-622:
------------------------------------
bq. IMO, this is a 0.1 release of Thrift. If the Ruby and OCaml bindings are broken... that is okay. That is what an early release is intended to discover.
I don't see it that way. If we have a known-good system we shouldn't knowingly introduce a regression without a good reason. This is not an "early release" for Thrift: a lot of people are already using it. We already know that the Ruby build works, so we don't need to "discover" that a change with (correct me if I'm wrong on this one, Todd) no technical merit breaks the build.
> Get Thrift into releasable form (eliminate dependencies, tidy licenses, etc)
> ----------------------------------------------------------------------------
>
> Key: THRIFT-622
> URL: https://issues.apache.org/jira/browse/THRIFT-622
> Project: Thrift
> Issue Type: Task
> Affects Versions: 0.1
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: thrift-622.txt, thrift-622.txt, thrift-622.txt
>
>
> I spoke with Joe Schaefer at ApacheCon the other day, and I believe these are the necessary changes to be kosher for a release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-622) Get Thrift into releasable form
(eliminate dependencies, tidy licenses, etc)
Posted by "Ben Taitelbaum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12782067#action_12782067 ]
Ben Taitelbaum commented on THRIFT-622:
---------------------------------------
We're depending on being able to build the ruby libraries as part of building thrift. As long as there's still a way to go into lib/rb and build a gem, I'll be happy.
> Get Thrift into releasable form (eliminate dependencies, tidy licenses, etc)
> ----------------------------------------------------------------------------
>
> Key: THRIFT-622
> URL: https://issues.apache.org/jira/browse/THRIFT-622
> Project: Thrift
> Issue Type: Task
> Affects Versions: 0.1
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: thrift-622.txt, thrift-622.txt, thrift-622.txt
>
>
> I spoke with Joe Schaefer at ApacheCon the other day, and I believe these are the necessary changes to be kosher for a release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-622) Get Thrift into releasable form
(eliminate dependencies, tidy licenses, etc)
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12776516#action_12776516 ]
Bryan Duxbury commented on THRIFT-622:
--------------------------------------
In regards to what this new makefile does for ruby, I think you sort of reinvented the wheel. We have a "Rakefile" in the ruby lib that does all the ruby build stuff. "rake package" will build the gem the way we like it and put it in lib/rb/pkg/version.
> Get Thrift into releasable form (eliminate dependencies, tidy licenses, etc)
> ----------------------------------------------------------------------------
>
> Key: THRIFT-622
> URL: https://issues.apache.org/jira/browse/THRIFT-622
> Project: Thrift
> Issue Type: Task
> Affects Versions: 0.1
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: thrift-622.txt, thrift-622.txt, thrift-622.txt
>
>
> I spoke with Joe Schaefer at ApacheCon the other day, and I believe these are the necessary changes to be kosher for a release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-622) Get Thrift into releasable form
(eliminate dependencies, tidy licenses, etc)
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12776286#action_12776286 ]
Todd Lipcon commented on THRIFT-622:
------------------------------------
bq. I don't see it that way. If we have a known-good system we shouldn't knowingly introduce a regression without a good reason
+1 on that
bq. correct me if I'm wrong on this one, Todd) no technical merit
I don't even know - I know so little about ruby that I couldn't tell you whether it's better, worse, or the same. Same goes for the OCaml bindings, though I think OCaml is more of a binary "does it compile" whereas changing setup.rb to gem may actually change the way installation works, etc. (note *may* - again, I don't know enough about ruby packaging to say for sure)
> Get Thrift into releasable form (eliminate dependencies, tidy licenses, etc)
> ----------------------------------------------------------------------------
>
> Key: THRIFT-622
> URL: https://issues.apache.org/jira/browse/THRIFT-622
> Project: Thrift
> Issue Type: Task
> Affects Versions: 0.1
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: thrift-622.txt, thrift-622.txt, thrift-622.txt
>
>
> I spoke with Joe Schaefer at ApacheCon the other day, and I believe these are the necessary changes to be kosher for a release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-622) Get Thrift into releasable form
(eliminate dependencies, tidy licenses, etc)
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12776300#action_12776300 ]
Bryan Duxbury commented on THRIFT-622:
--------------------------------------
As a Ruby user, I personally won't miss the ruby setup.rb option. I use the gem-based distribution method, and I don't see any reason you'd want to use the other. Maybe other people use it, but I always got the impression it was an artifact of the original ruby libraries being coded by someone who was not a ruby super user.
> Get Thrift into releasable form (eliminate dependencies, tidy licenses, etc)
> ----------------------------------------------------------------------------
>
> Key: THRIFT-622
> URL: https://issues.apache.org/jira/browse/THRIFT-622
> Project: Thrift
> Issue Type: Task
> Affects Versions: 0.1
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: thrift-622.txt, thrift-622.txt, thrift-622.txt
>
>
> I spoke with Joe Schaefer at ApacheCon the other day, and I believe these are the necessary changes to be kosher for a release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-622) Get Thrift into releasable form
(eliminate dependencies, tidy licenses, etc)
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784088#action_12784088 ]
Todd Lipcon commented on THRIFT-622:
------------------------------------
Hey Bryan,
I tried building a package using rake, but it seems to depend on setup.rb:
{noformat}
todd@todd-laptop:~/thrift_pkg/thrift/lib/rb$ rake package
(in /home/todd/thrift_pkg/thrift/lib/rb)
/usr/lib/ruby/1.8/rake/gempackagetask.rb:13:Warning: Gem::manage_gems is deprecated and will be removed on or after March 2009.
rake aborted!
Don't know how to build task 'setup.rb'
{noformat}
Any objection to the Makefile/gem build thing in my original patch, then?
> Get Thrift into releasable form (eliminate dependencies, tidy licenses, etc)
> ----------------------------------------------------------------------------
>
> Key: THRIFT-622
> URL: https://issues.apache.org/jira/browse/THRIFT-622
> Project: Thrift
> Issue Type: Task
> Affects Versions: 0.1
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: thrift-622.txt, thrift-622.txt, thrift-622.txt, v1-0001-THRIFT-622.-ruby-Eliminate-setup.rb.patch
>
>
> I spoke with Joe Schaefer at ApacheCon the other day, and I believe these are the necessary changes to be kosher for a release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-622) Update NOTICE to call out all
non-Apache2 contributions
Posted by "Greg Stein (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12775450#action_12775450 ]
Greg Stein commented on THRIFT-622:
-----------------------------------
* I don't think that we can distribute *any* LGPL software, even if it is optional. the ruby stuff needs to be removed, or we need to find another solution
* it would be nice if David Reiss did not ask for his name in there
* likewise for Facebook
* the contributions made under the TSL: by FB employees, or third-parties before the relicensing?
The acknowledgement of copyright (by David and Facebook) can be waived by them. Under David's ICLA and FB's software grant, they have already provided us license to distribute their works. No further acknowledgement would be needed if they provide this waiver. (which would be nice to clean up the NOTICE file)
Also note that we have an ALv2-licensed MD5 implement in APR (see apr-util/crypto/apr_md5.[ch]). That still requires an entry in the NOTICE file, but you'll see that it is quite a bit shorter than in the suggested file.
At the beginning of the NOTICE file, put something like this:
Apache Thrift
Copyright (c) 2009 The Apache Software Foundation.
This product includes software developed by
The Apache Software Foundation (http://www.apache.org/).
... then lead into the various, additional subcomponents.
> Update NOTICE to call out all non-Apache2 contributions
> -------------------------------------------------------
>
> Key: THRIFT-622
> URL: https://issues.apache.org/jira/browse/THRIFT-622
> Project: Thrift
> Issue Type: Task
> Affects Versions: 0.1
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: thrift-622.txt
>
>
> I spoke with Joe Schaefer at ApacheCon the other day, and I believe these are the necessary changes to be kosher for a release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-622) Get Thrift into releasable form
(eliminate dependencies, tidy licenses, etc)
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12776293#action_12776293 ]
David Reiss commented on THRIFT-622:
------------------------------------
bq. so all that stuff has to disappear at some point.
I sincerely hope that the response to LEGAL-58 will indicate that that is not the case.
> Get Thrift into releasable form (eliminate dependencies, tidy licenses, etc)
> ----------------------------------------------------------------------------
>
> Key: THRIFT-622
> URL: https://issues.apache.org/jira/browse/THRIFT-622
> Project: Thrift
> Issue Type: Task
> Affects Versions: 0.1
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: thrift-622.txt, thrift-622.txt, thrift-622.txt
>
>
> I spoke with Joe Schaefer at ApacheCon the other day, and I believe these are the necessary changes to be kosher for a release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-622) Get Thrift into releasable form
(eliminate dependencies, tidy licenses, etc)
Posted by "Kevin Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12780922#action_12780922 ]
Kevin Clark commented on THRIFT-622:
------------------------------------
I agree the current patch is a little redundant, but wouldn't oppose inclusion if it'll move things along.
> Get Thrift into releasable form (eliminate dependencies, tidy licenses, etc)
> ----------------------------------------------------------------------------
>
> Key: THRIFT-622
> URL: https://issues.apache.org/jira/browse/THRIFT-622
> Project: Thrift
> Issue Type: Task
> Affects Versions: 0.1
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: thrift-622.txt, thrift-622.txt, thrift-622.txt
>
>
> I spoke with Joe Schaefer at ApacheCon the other day, and I believe these are the necessary changes to be kosher for a release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-622) Get Thrift into releasable form
(eliminate dependencies, tidy licenses, etc)
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12782086#action_12782086 ]
Bryan Duxbury commented on THRIFT-622:
--------------------------------------
Yeah, it won't be a problem. You can do:
{code}
$ cd lib/rb
$ rake package
{code}
to build a gem.
> Get Thrift into releasable form (eliminate dependencies, tidy licenses, etc)
> ----------------------------------------------------------------------------
>
> Key: THRIFT-622
> URL: https://issues.apache.org/jira/browse/THRIFT-622
> Project: Thrift
> Issue Type: Task
> Affects Versions: 0.1
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: thrift-622.txt, thrift-622.txt, thrift-622.txt
>
>
> I spoke with Joe Schaefer at ApacheCon the other day, and I believe these are the necessary changes to be kosher for a release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-622) Get Thrift into releasable form
(eliminate dependencies, tidy licenses, etc)
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784090#action_12784090 ]
David Reiss commented on THRIFT-622:
------------------------------------
Sounds good to me. I see three patches from you. Is any the final version?
> Get Thrift into releasable form (eliminate dependencies, tidy licenses, etc)
> ----------------------------------------------------------------------------
>
> Key: THRIFT-622
> URL: https://issues.apache.org/jira/browse/THRIFT-622
> Project: Thrift
> Issue Type: Task
> Affects Versions: 0.1
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: thrift-622.txt, thrift-622.txt, thrift-622.txt, v1-0001-THRIFT-622.-ruby-Eliminate-setup.rb.patch
>
>
> I spoke with Joe Schaefer at ApacheCon the other day, and I believe these are the necessary changes to be kosher for a release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-622) Get Thrift into releasable form
(eliminate dependencies, tidy licenses, etc)
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated THRIFT-622:
-------------------------------
Summary: Get Thrift into releasable form (eliminate dependencies, tidy licenses, etc) (was: Update NOTICE to call out all non-Apache2 contributions)
> Get Thrift into releasable form (eliminate dependencies, tidy licenses, etc)
> ----------------------------------------------------------------------------
>
> Key: THRIFT-622
> URL: https://issues.apache.org/jira/browse/THRIFT-622
> Project: Thrift
> Issue Type: Task
> Affects Versions: 0.1
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: thrift-622.txt, thrift-622.txt, thrift-622.txt
>
>
> I spoke with Joe Schaefer at ApacheCon the other day, and I believe these are the necessary changes to be kosher for a release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-622) Get Thrift into releasable form
(eliminate dependencies, tidy licenses, etc)
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12782061#action_12782061 ]
David Reiss commented on THRIFT-622:
------------------------------------
We just got a response on LEGAL-58. It looks like it is fine to include OCamlMakefile, so I think we should leave that alone for now, at least. For Ruby, it sounds like none of our big Ruby users are using it or the automake->ruby integration. Therefore, I propose that we just drop it (and get some third-party code out of our repo!) and make "./configure && make" just skip over Ruby. We can leave a note that gives instructions on how to manually run rake (which, if I understand properly, is what you guys are already doing). If there is demand to reintegrate it with automake, we can do that later.
Thoughts?
> Get Thrift into releasable form (eliminate dependencies, tidy licenses, etc)
> ----------------------------------------------------------------------------
>
> Key: THRIFT-622
> URL: https://issues.apache.org/jira/browse/THRIFT-622
> Project: Thrift
> Issue Type: Task
> Affects Versions: 0.1
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: thrift-622.txt, thrift-622.txt, thrift-622.txt
>
>
> I spoke with Joe Schaefer at ApacheCon the other day, and I believe these are the necessary changes to be kosher for a release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-622) Get Thrift into releasable form
(eliminate dependencies, tidy licenses, etc)
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12776306#action_12776306 ]
David Reiss commented on THRIFT-622:
------------------------------------
He's working on a pretty high-priority project right now. I'd prefer to get an answer on how necessary this is first.
> Get Thrift into releasable form (eliminate dependencies, tidy licenses, etc)
> ----------------------------------------------------------------------------
>
> Key: THRIFT-622
> URL: https://issues.apache.org/jira/browse/THRIFT-622
> Project: Thrift
> Issue Type: Task
> Affects Versions: 0.1
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: thrift-622.txt, thrift-622.txt, thrift-622.txt
>
>
> I spoke with Joe Schaefer at ApacheCon the other day, and I believe these are the necessary changes to be kosher for a release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-622) Update NOTICE to call out all
non-Apache2 contributions
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774391#action_12774391 ]
Todd Lipcon commented on THRIFT-622:
------------------------------------
We may need to also add a notice saying "Some portions of this file licensed under the Thrift Software License" to all of the files with non-CLAed contributions. If this is the case let me know and I will add a new patch.
> Update NOTICE to call out all non-Apache2 contributions
> -------------------------------------------------------
>
> Key: THRIFT-622
> URL: https://issues.apache.org/jira/browse/THRIFT-622
> Project: Thrift
> Issue Type: Task
> Affects Versions: 0.1
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: thrift-622.txt
>
>
> I spoke with Joe Schaefer at ApacheCon the other day, and I believe these are the necessary changes to be kosher for a release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-622) Update NOTICE to call out all
non-Apache2 contributions
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12775985#action_12775985 ]
David Reiss commented on THRIFT-622:
------------------------------------
I think all of the NOTICE entries for the .m4 files can be safely removed if necessary. Apache HTTPD has several files with very similar licenses (e.g., ./srclib/apr-util/xml/expat/aclocal.m4) that are not mentioned in its NOTICE file.
> Update NOTICE to call out all non-Apache2 contributions
> -------------------------------------------------------
>
> Key: THRIFT-622
> URL: https://issues.apache.org/jira/browse/THRIFT-622
> Project: Thrift
> Issue Type: Task
> Affects Versions: 0.1
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: thrift-622.txt
>
>
> I spoke with Joe Schaefer at ApacheCon the other day, and I believe these are the necessary changes to be kosher for a release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-622) Get Thrift into releasable form
(eliminate dependencies, tidy licenses, etc)
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12776309#action_12776309 ]
Todd Lipcon commented on THRIFT-622:
------------------------------------
OK, another angle for the ocaml stuff: do you guys actually use it, or was it a project "for fun"? There have been essentially no changes since Aug '07.
I agree with you in principle that regression for bureaucratic reasons is lame, but if no one uses this code, I'd rather have a release in which it's broken than no release at all. For the Ruby code I think breaking it would be a blocker since it's clearly in use by many.
I don't know if the ASF lawyers are any different, but in my experience waiting on lawyers to deliver an opinion is fruitless.
> Get Thrift into releasable form (eliminate dependencies, tidy licenses, etc)
> ----------------------------------------------------------------------------
>
> Key: THRIFT-622
> URL: https://issues.apache.org/jira/browse/THRIFT-622
> Project: Thrift
> Issue Type: Task
> Affects Versions: 0.1
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: thrift-622.txt, thrift-622.txt, thrift-622.txt
>
>
> I spoke with Joe Schaefer at ApacheCon the other day, and I believe these are the necessary changes to be kosher for a release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-622) Get Thrift into releasable form
(eliminate dependencies, tidy licenses, etc)
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786745#action_12786745 ]
David Reiss commented on THRIFT-622:
------------------------------------
LGTM.
> Get Thrift into releasable form (eliminate dependencies, tidy licenses, etc)
> ----------------------------------------------------------------------------
>
> Key: THRIFT-622
> URL: https://issues.apache.org/jira/browse/THRIFT-622
> Project: Thrift
> Issue Type: Task
> Affects Versions: 0.1
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: thrift-622-20091130.txt, thrift-622.txt, thrift-622.txt, thrift-622.txt, thrift-622.txt, v1-0001-THRIFT-622.-ruby-Eliminate-setup.rb.patch
>
>
> I spoke with Joe Schaefer at ApacheCon the other day, and I believe these are the necessary changes to be kosher for a release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-622) Get Thrift into releasable form
(eliminate dependencies, tidy licenses, etc)
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12776313#action_12776313 ]
David Reiss commented on THRIFT-622:
------------------------------------
It is not actively used within Facebook.
> Get Thrift into releasable form (eliminate dependencies, tidy licenses, etc)
> ----------------------------------------------------------------------------
>
> Key: THRIFT-622
> URL: https://issues.apache.org/jira/browse/THRIFT-622
> Project: Thrift
> Issue Type: Task
> Affects Versions: 0.1
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: thrift-622.txt, thrift-622.txt, thrift-622.txt
>
>
> I spoke with Joe Schaefer at ApacheCon the other day, and I believe these are the necessary changes to be kosher for a release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-622) Get Thrift into releasable form
(eliminate dependencies, tidy licenses, etc)
Posted by "Greg Stein (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12776291#action_12776291 ]
Greg Stein commented on THRIFT-622:
-----------------------------------
@David: that's fine. Just saying that from my perspective, I'd much rather see *any* release, than worry about whether something got broken. Releases should be easy. If the ruby or OCaml stuff got broken, then fine... fix it and release one week later. A release doesn't have to be difficult. They don't have to be six months apart. Push. "whoops". Push again.
Attempting for perfection leads to never releasing :-P
That said, I also understand the frustration of breaking code for "bureaucratic reasons", and it doesn't feel good. But that is a temporary hardship. We're trying to shift everything towards ALv2, so all that stuff has to disappear at *some* point.
> Get Thrift into releasable form (eliminate dependencies, tidy licenses, etc)
> ----------------------------------------------------------------------------
>
> Key: THRIFT-622
> URL: https://issues.apache.org/jira/browse/THRIFT-622
> Project: Thrift
> Issue Type: Task
> Affects Versions: 0.1
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: thrift-622.txt, thrift-622.txt, thrift-622.txt
>
>
> I spoke with Joe Schaefer at ApacheCon the other day, and I believe these are the necessary changes to be kosher for a release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-622) Get Thrift into releasable form
(eliminate dependencies, tidy licenses, etc)
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12776276#action_12776276 ]
David Reiss commented on THRIFT-622:
------------------------------------
I'd love to hear back on LEGAL-58 before we knowingly make Thrift's build process worse.
> Get Thrift into releasable form (eliminate dependencies, tidy licenses, etc)
> ----------------------------------------------------------------------------
>
> Key: THRIFT-622
> URL: https://issues.apache.org/jira/browse/THRIFT-622
> Project: Thrift
> Issue Type: Task
> Affects Versions: 0.1
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: thrift-622.txt, thrift-622.txt, thrift-622.txt
>
>
> I spoke with Joe Schaefer at ApacheCon the other day, and I believe these are the necessary changes to be kosher for a release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (THRIFT-622) Get Thrift into releasable form
(eliminate dependencies, tidy licenses, etc)
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon resolved THRIFT-622.
--------------------------------
Resolution: Fixed
Fix Version/s: 0.1
Commited. Thanks for the reviews and help, everyone.
> Get Thrift into releasable form (eliminate dependencies, tidy licenses, etc)
> ----------------------------------------------------------------------------
>
> Key: THRIFT-622
> URL: https://issues.apache.org/jira/browse/THRIFT-622
> Project: Thrift
> Issue Type: Task
> Affects Versions: 0.1
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.1
>
> Attachments: thrift-622-20091130.txt, thrift-622.txt, thrift-622.txt, thrift-622.txt, thrift-622.txt, v1-0001-THRIFT-622.-ruby-Eliminate-setup.rb.patch
>
>
> I spoke with Joe Schaefer at ApacheCon the other day, and I believe these are the necessary changes to be kosher for a release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-622) Update NOTICE to call out all
non-Apache2 contributions
Posted by "Joe Schaefer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12776221#action_12776221 ]
Joe Schaefer commented on THRIFT-622:
-------------------------------------
Technically the stuff Todd has added to the NOTICE file belongs in LICENSE.
Also each source file that has thrift-licensed contributions needs to have a
note to that effect in the source file.
With respect to the LGPL issue, I filed https://issues.apache.org/jira/browse/LEGAL-58
a while back and have received no response to date. I can try pinging the legal
team again to see if they're willing to budge at all, but my guess is that the best
I will be able to do is get an exception to the policy which terminates upon graduation.
In other words, you'll need to address this issue prior to graduation by either asking
for the LGPL author to give you a different license, by reimplementing it yourselves,
or by pulling all the dependent code.
> Update NOTICE to call out all non-Apache2 contributions
> -------------------------------------------------------
>
> Key: THRIFT-622
> URL: https://issues.apache.org/jira/browse/THRIFT-622
> Project: Thrift
> Issue Type: Task
> Affects Versions: 0.1
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: thrift-622.txt, thrift-622.txt
>
>
> I spoke with Joe Schaefer at ApacheCon the other day, and I believe these are the necessary changes to be kosher for a release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-622) Get Thrift into releasable form
(eliminate dependencies, tidy licenses, etc)
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784324#action_12784324 ]
Todd Lipcon commented on THRIFT-622:
------------------------------------
bq. A trailing space was added to the last line of the comment in the csharp generator.
Feel free to remove before committing - won't have a chance to make a new patch for just this until tonight at the earliest :)
bq. Why use docblock comments in Java?
I just borrowed the comment block from Hadoop - don't know why that's the standard, but that's what M-x apache-insert-license does in my emacs :)
bq. Why is the "old thrift license" notice in every generator
In one of the mailing list threads I posted a list of hashes that were missing CLAs. I then fed those hashes into some mondo command line that inserted the "old thrift license" notice at the top of every file that was modified by one of those commits. I don't recall for sure which non-CLAed commit it was that touched all of these, but if my memory serves me it was some change that made the compiler compile on win32.
> Get Thrift into releasable form (eliminate dependencies, tidy licenses, etc)
> ----------------------------------------------------------------------------
>
> Key: THRIFT-622
> URL: https://issues.apache.org/jira/browse/THRIFT-622
> Project: Thrift
> Issue Type: Task
> Affects Versions: 0.1
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: thrift-622-20091130.txt, thrift-622.txt, thrift-622.txt, thrift-622.txt, v1-0001-THRIFT-622.-ruby-Eliminate-setup.rb.patch
>
>
> I spoke with Joe Schaefer at ApacheCon the other day, and I believe these are the necessary changes to be kosher for a release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-622) Get Thrift into releasable form
(eliminate dependencies, tidy licenses, etc)
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated THRIFT-622:
-------------------------------
Attachment: thrift-622-20091130.txt
Attaching hopefully-final patch.
- put back OCamlMakefile and setup.rb
- added them back into the LICENSE file
> Get Thrift into releasable form (eliminate dependencies, tidy licenses, etc)
> ----------------------------------------------------------------------------
>
> Key: THRIFT-622
> URL: https://issues.apache.org/jira/browse/THRIFT-622
> Project: Thrift
> Issue Type: Task
> Affects Versions: 0.1
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: thrift-622-20091130.txt, thrift-622.txt, thrift-622.txt, thrift-622.txt, v1-0001-THRIFT-622.-ruby-Eliminate-setup.rb.patch
>
>
> I spoke with Joe Schaefer at ApacheCon the other day, and I believe these are the necessary changes to be kosher for a release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-622) Update NOTICE to call out all
non-Apache2 contributions
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated THRIFT-622:
-------------------------------
Attachment: thrift-622.txt
I went to add the top notice you asked for, and found it's already there:
{quote}
Apache Thrift
Copyright 2006-2009 The Apache Software Foundation, et al.
This product includes software developed at
The Apache Software Foundation (http://www.apache.org/).
{quote}
This new patch is the same as the previous one, except that it removes the specific copyright callouts for David Reiss and Facebook (David OKed this on the mailing list)
I did not make the md5 change to the different implementation. The current implementation is under the zlib license (http://en.wikipedia.org/wiki/Zlib_License) which is listed as compatible at: http://www.apache.org/legal/3party.html
> Update NOTICE to call out all non-Apache2 contributions
> -------------------------------------------------------
>
> Key: THRIFT-622
> URL: https://issues.apache.org/jira/browse/THRIFT-622
> Project: Thrift
> Issue Type: Task
> Affects Versions: 0.1
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: thrift-622.txt, thrift-622.txt
>
>
> I spoke with Joe Schaefer at ApacheCon the other day, and I believe these are the necessary changes to be kosher for a release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-622) Get Thrift into releasable form
(eliminate dependencies, tidy licenses, etc)
Posted by "Kevin Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12776343#action_12776343 ]
Kevin Clark commented on THRIFT-622:
------------------------------------
I don't think the Ruby bindings will be severely hampered by the removal of setup.rb. That it existed made packaging easier under the build system I was working on at the time. At this point it doesn't cause an issue for me and I don't know of anyone else who would argue it should stick around. If it's really a blocker for release (seriously ASF?) I say we cut it.
I'll take a look at the diff in the morning with fresh eyes.
> Get Thrift into releasable form (eliminate dependencies, tidy licenses, etc)
> ----------------------------------------------------------------------------
>
> Key: THRIFT-622
> URL: https://issues.apache.org/jira/browse/THRIFT-622
> Project: Thrift
> Issue Type: Task
> Affects Versions: 0.1
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: thrift-622.txt, thrift-622.txt, thrift-622.txt
>
>
> I spoke with Joe Schaefer at ApacheCon the other day, and I believe these are the necessary changes to be kosher for a release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-622) Get Thrift into releasable form
(eliminate dependencies, tidy licenses, etc)
Posted by "Greg Stein (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12776280#action_12776280 ]
Greg Stein commented on THRIFT-622:
-----------------------------------
IMO, this is a 0.1 release of Thrift. If the Ruby and OCaml bindings are broken... that is okay. That is what an early release is intended to discover.
Sorry on missing the leader on the NOTICE file; thought the patch was providing the whole file. In any case... I'm glad the LICENSE and NOTICE is getting all sorted out. And that the rewrites are getting all of this simplified. It is much better for our downstream users.
Thanks!
> Get Thrift into releasable form (eliminate dependencies, tidy licenses, etc)
> ----------------------------------------------------------------------------
>
> Key: THRIFT-622
> URL: https://issues.apache.org/jira/browse/THRIFT-622
> Project: Thrift
> Issue Type: Task
> Affects Versions: 0.1
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: thrift-622.txt, thrift-622.txt, thrift-622.txt
>
>
> I spoke with Joe Schaefer at ApacheCon the other day, and I believe these are the necessary changes to be kosher for a release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-622) Get Thrift into releasable form
(eliminate dependencies, tidy licenses, etc)
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated THRIFT-622:
-------------------------------
Attachment: thrift-622.txt
New revision:
- Removed "some contributions under old license" stuff where the contributions were trivial (eg variable renames, substitution of macros for functions for win32 compat, etc)
- Got rid of trailing whitespaces
> Get Thrift into releasable form (eliminate dependencies, tidy licenses, etc)
> ----------------------------------------------------------------------------
>
> Key: THRIFT-622
> URL: https://issues.apache.org/jira/browse/THRIFT-622
> Project: Thrift
> Issue Type: Task
> Affects Versions: 0.1
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: thrift-622-20091130.txt, thrift-622.txt, thrift-622.txt, thrift-622.txt, thrift-622.txt, v1-0001-THRIFT-622.-ruby-Eliminate-setup.rb.patch
>
>
> I spoke with Joe Schaefer at ApacheCon the other day, and I believe these are the necessary changes to be kosher for a release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-622) Update NOTICE to call out all
non-Apache2 contributions
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated THRIFT-622:
-------------------------------
Attachment: thrift-622.txt
This new diff has the following changes:
- rewrote OCaml build process using my own Makefile - it probably isn't as good. It may not even be correct, since I barely know anything about OCaml. This removes one LGPL dependency (OCamlMakefile)
- rewrote ruby build to use "gem build" and the extconf.rb-generated Makefile. This removes the other LGPL dependency (setup.rb)
- Put a small header in every file that I found to be touched by a non-CLAed contribution pre-incubator.
- Moved the majority of the contents of NOTICE to LICENSE
- I rolled the contents of the THRIFT-618 patch into this. I'm going to rename this issue for its new, larger scope, and mark 618 as dup.
Given I am a user of neither the ruby nor ocaml bindings, I wasn't really able to verify that my builds aren't completely awful. I'm counting on the users of those components to either tell me what to fix or to put an improved patch up.
For those who prefer git, this branch is available at http://git.thrift-rpc.org/?p=thrift.git;a=shortlog;h=refs/heads/pri/tlipcon/thrift-622
> Update NOTICE to call out all non-Apache2 contributions
> -------------------------------------------------------
>
> Key: THRIFT-622
> URL: https://issues.apache.org/jira/browse/THRIFT-622
> Project: Thrift
> Issue Type: Task
> Affects Versions: 0.1
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: thrift-622.txt, thrift-622.txt, thrift-622.txt
>
>
> I spoke with Joe Schaefer at ApacheCon the other day, and I believe these are the necessary changes to be kosher for a release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-622) Get Thrift into releasable form
(eliminate dependencies, tidy licenses, etc)
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12782076#action_12782076 ]
David Reiss commented on THRIFT-622:
------------------------------------
Can you comment on that, Bryan?
> Get Thrift into releasable form (eliminate dependencies, tidy licenses, etc)
> ----------------------------------------------------------------------------
>
> Key: THRIFT-622
> URL: https://issues.apache.org/jira/browse/THRIFT-622
> Project: Thrift
> Issue Type: Task
> Affects Versions: 0.1
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: thrift-622.txt, thrift-622.txt, thrift-622.txt
>
>
> I spoke with Joe Schaefer at ApacheCon the other day, and I believe these are the necessary changes to be kosher for a release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-622) Get Thrift into releasable form
(eliminate dependencies, tidy licenses, etc)
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12782063#action_12782063 ]
Bryan Duxbury commented on THRIFT-622:
--------------------------------------
+1
> Get Thrift into releasable form (eliminate dependencies, tidy licenses, etc)
> ----------------------------------------------------------------------------
>
> Key: THRIFT-622
> URL: https://issues.apache.org/jira/browse/THRIFT-622
> Project: Thrift
> Issue Type: Task
> Affects Versions: 0.1
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: thrift-622.txt, thrift-622.txt, thrift-622.txt
>
>
> I spoke with Joe Schaefer at ApacheCon the other day, and I believe these are the necessary changes to be kosher for a release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-622) Update NOTICE to call out all
non-Apache2 contributions
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12776024#action_12776024 ]
Todd Lipcon commented on THRIFT-622:
------------------------------------
bq. I don't think that we can distribute any LGPL software, even if it is optional. the ruby stuff needs to be removed, or we need to find another solution
This mailing list message from Joe Schaefer seems to indicate these LGPL dependencies are OK since they're only build files:
http://mail-archives.apache.org/mod_mbox/incubator-thrift-dev/200908.mbox/%3C913590.3473.qm@web54403.mail.yahoo.com%3E
bq. the contributions made under the TSL: by FB employees, or third-parties before the relicensing?
To make this patch, I looked through the svn logs from the period before Thrift entered the incubator, and made a list of all patches contributed by individuals or corporations who don't have an ICLA on file. Then, I simply took the union of all files touched by those patches, and added them to the NOTICE file as containing some contributions made under the Thrift license.
I'll make up another patch that includes the header text you suggested. Is the md5 thing a blocker for release or can we put that off until an 0.2?
> Update NOTICE to call out all non-Apache2 contributions
> -------------------------------------------------------
>
> Key: THRIFT-622
> URL: https://issues.apache.org/jira/browse/THRIFT-622
> Project: Thrift
> Issue Type: Task
> Affects Versions: 0.1
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: thrift-622.txt
>
>
> I spoke with Joe Schaefer at ApacheCon the other day, and I believe these are the necessary changes to be kosher for a release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-622) Update NOTICE to call out all
non-Apache2 contributions
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12776225#action_12776225 ]
Todd Lipcon commented on THRIFT-622:
------------------------------------
bq. Technically the stuff Todd has added to the NOTICE file belongs in LICENSE.
OK, what belongs in NOTICE then? Hadoop's is just "This product includes software developed by The Apache Software Foundation (http://www.apache.org/)." Is that all we need?
bq. Also each source file that has thrift-licensed contributions needs to have a note to that effect in the source file.
OK, I'll go through and do this.
Regarding LGPL, I'll hunt around and see if I can find replacements for those build scripts.
> Update NOTICE to call out all non-Apache2 contributions
> -------------------------------------------------------
>
> Key: THRIFT-622
> URL: https://issues.apache.org/jira/browse/THRIFT-622
> Project: Thrift
> Issue Type: Task
> Affects Versions: 0.1
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: thrift-622.txt, thrift-622.txt
>
>
> I spoke with Joe Schaefer at ApacheCon the other day, and I believe these are the necessary changes to be kosher for a release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-622) Get Thrift into releasable form
(eliminate dependencies, tidy licenses, etc)
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784300#action_12784300 ]
David Reiss commented on THRIFT-622:
------------------------------------
A few tiny nits. A trailing space was added to the last line of the comment in the csharp generator. Why use docblock comments in Java? Why is the "old thrift license" notice in every generator (sorry if this is in another issue and I just can't find it)?
> Get Thrift into releasable form (eliminate dependencies, tidy licenses, etc)
> ----------------------------------------------------------------------------
>
> Key: THRIFT-622
> URL: https://issues.apache.org/jira/browse/THRIFT-622
> Project: Thrift
> Issue Type: Task
> Affects Versions: 0.1
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: thrift-622-20091130.txt, thrift-622.txt, thrift-622.txt, thrift-622.txt, v1-0001-THRIFT-622.-ruby-Eliminate-setup.rb.patch
>
>
> I spoke with Joe Schaefer at ApacheCon the other day, and I believe these are the necessary changes to be kosher for a release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-622) Get Thrift into releasable form
(eliminate dependencies, tidy licenses, etc)
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12776275#action_12776275 ]
Todd Lipcon commented on THRIFT-622:
------------------------------------
JIRA is displaying the patches with incorrect timestamps for whatever reason. The one you want to review has the blue colored link and is 144K.
> Get Thrift into releasable form (eliminate dependencies, tidy licenses, etc)
> ----------------------------------------------------------------------------
>
> Key: THRIFT-622
> URL: https://issues.apache.org/jira/browse/THRIFT-622
> Project: Thrift
> Issue Type: Task
> Affects Versions: 0.1
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: thrift-622.txt, thrift-622.txt, thrift-622.txt
>
>
> I spoke with Joe Schaefer at ApacheCon the other day, and I believe these are the necessary changes to be kosher for a release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-622) Update NOTICE to call out all
non-Apache2 contributions
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated THRIFT-622:
-------------------------------
Attachment: thrift-622.txt
> Update NOTICE to call out all non-Apache2 contributions
> -------------------------------------------------------
>
> Key: THRIFT-622
> URL: https://issues.apache.org/jira/browse/THRIFT-622
> Project: Thrift
> Issue Type: Task
> Affects Versions: 0.1
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: thrift-622.txt
>
>
> I spoke with Joe Schaefer at ApacheCon the other day, and I believe these are the necessary changes to be kosher for a release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-622) Get Thrift into releasable form
(eliminate dependencies, tidy licenses, etc)
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784332#action_12784332 ]
David Reiss commented on THRIFT-622:
------------------------------------
Oh. I thought you were going to commit. :)
Given that the imeem guys have already sent in their paperwork and the triviality of the changes to the generators, I think we can leave those out. Obviously, larger contributions by them or other changes to the generators should stay.
> Get Thrift into releasable form (eliminate dependencies, tidy licenses, etc)
> ----------------------------------------------------------------------------
>
> Key: THRIFT-622
> URL: https://issues.apache.org/jira/browse/THRIFT-622
> Project: Thrift
> Issue Type: Task
> Affects Versions: 0.1
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: thrift-622-20091130.txt, thrift-622.txt, thrift-622.txt, thrift-622.txt, v1-0001-THRIFT-622.-ruby-Eliminate-setup.rb.patch
>
>
> I spoke with Joe Schaefer at ApacheCon the other day, and I believe these are the necessary changes to be kosher for a release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-622) Get Thrift into releasable form
(eliminate dependencies, tidy licenses, etc)
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Reiss updated THRIFT-622:
-------------------------------
Attachment: v1-0001-THRIFT-622.-ruby-Eliminate-setup.rb.patch
> Get Thrift into releasable form (eliminate dependencies, tidy licenses, etc)
> ----------------------------------------------------------------------------
>
> Key: THRIFT-622
> URL: https://issues.apache.org/jira/browse/THRIFT-622
> Project: Thrift
> Issue Type: Task
> Affects Versions: 0.1
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: thrift-622.txt, thrift-622.txt, thrift-622.txt, v1-0001-THRIFT-622.-ruby-Eliminate-setup.rb.patch
>
>
> I spoke with Joe Schaefer at ApacheCon the other day, and I believe these are the necessary changes to be kosher for a release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-622) Get Thrift into releasable form
(eliminate dependencies, tidy licenses, etc)
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784089#action_12784089 ]
Todd Lipcon commented on THRIFT-622:
------------------------------------
hm, actually just took another look at LEGAL-58 - it sounds like setup.rb is also deemed OK. So perhaps we should just leave it all alone, and just commit the patches that add missing license headers, etc?
> Get Thrift into releasable form (eliminate dependencies, tidy licenses, etc)
> ----------------------------------------------------------------------------
>
> Key: THRIFT-622
> URL: https://issues.apache.org/jira/browse/THRIFT-622
> Project: Thrift
> Issue Type: Task
> Affects Versions: 0.1
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: thrift-622.txt, thrift-622.txt, thrift-622.txt, v1-0001-THRIFT-622.-ruby-Eliminate-setup.rb.patch
>
>
> I spoke with Joe Schaefer at ApacheCon the other day, and I believe these are the necessary changes to be kosher for a release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-622) Get Thrift into releasable form
(eliminate dependencies, tidy licenses, etc)
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12776305#action_12776305 ]
Todd Lipcon commented on THRIFT-622:
------------------------------------
Bryan: do you have some time to verify the gem-based thing I did is reasonable? I based it somewhat off a gem spec file I found on rubyforge for Thrift, done in part by Kevin Clark, I believe. So, Kevin, if you're out there, I'd appreciate a review as well.
iproctor, if you're out there and can verify the OCaml changes that would be swell (David, counting on you to poke him if he's still at FB)
> Get Thrift into releasable form (eliminate dependencies, tidy licenses, etc)
> ----------------------------------------------------------------------------
>
> Key: THRIFT-622
> URL: https://issues.apache.org/jira/browse/THRIFT-622
> Project: Thrift
> Issue Type: Task
> Affects Versions: 0.1
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: thrift-622.txt, thrift-622.txt, thrift-622.txt
>
>
> I spoke with Joe Schaefer at ApacheCon the other day, and I believe these are the necessary changes to be kosher for a release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-622) Update NOTICE to call out all
non-Apache2 contributions
Posted by "Joe Schaefer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12776230#action_12776230 ]
Joe Schaefer commented on THRIFT-622:
-------------------------------------
http://incubator.apache.org/guides/releasemanagement.html#best-practice-license
explains what belongs in the LICENSE and NOTICE files.
> Update NOTICE to call out all non-Apache2 contributions
> -------------------------------------------------------
>
> Key: THRIFT-622
> URL: https://issues.apache.org/jira/browse/THRIFT-622
> Project: Thrift
> Issue Type: Task
> Affects Versions: 0.1
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: thrift-622.txt, thrift-622.txt
>
>
> I spoke with Joe Schaefer at ApacheCon the other day, and I believe these are the necessary changes to be kosher for a release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.