You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/05/18 20:00:56 UTC

[GitHub] [incubator-pinot] GSharayu opened a new issue #6937: Fix the handling of time and date time columns in Flag Query Rule, Bloom Filter Rule, Sorted Index rule

GSharayu opened a new issue #6937:
URL: https://github.com/apache/incubator-pinot/issues/6937


   Fix the handling of time and date time columns and remove corresponding limitations	
   FlagQueryRule - Flags queries with tables that have time column (deprecated) or one or more DateTime columns (new way of specifying time columns) but don't use it in queries in the filter clause as a feedback to the user that they should consider using the time column as a filter. Two things need to be fixed in this rule
   
   Should also consider DateTime columns in addition to the Time column
   Fix a bug - if the schema of the table doesn't have a time/datetime column(s), it is stored as null and thus flags queries even for the tables that don't have such columns in the schema because it checks the presence of null in the set of filter columns. 
   This will also require some cleanup in InputManager.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [incubator-pinot] siddharthteotia closed issue #6937: Fix the handling of time and date time columns in rule engine

Posted by GitBox <gi...@apache.org>.
siddharthteotia closed issue #6937:
URL: https://github.com/apache/incubator-pinot/issues/6937


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [incubator-pinot] siddharthteotia commented on issue #6937: Fix the handling of time and date time columns in rule engine

Posted by GitBox <gi...@apache.org>.
siddharthteotia commented on issue #6937:
URL: https://github.com/apache/incubator-pinot/issues/6937#issuecomment-854336978


   Closed by PR - https://github.com/apache/incubator-pinot/pull/6938


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [incubator-pinot] siddharthteotia closed issue #6937: Fix the handling of time and date time columns in rule engine

Posted by GitBox <gi...@apache.org>.
siddharthteotia closed issue #6937:
URL: https://github.com/apache/incubator-pinot/issues/6937


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [incubator-pinot] siddharthteotia commented on issue #6937: Fix the handling of time and date time columns in rule engine

Posted by GitBox <gi...@apache.org>.
siddharthteotia commented on issue #6937:
URL: https://github.com/apache/incubator-pinot/issues/6937#issuecomment-854336978


   Closed by PR - https://github.com/apache/incubator-pinot/pull/6938


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org