You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Nikhil P <np...@gmail.com> on 2019/04/18 10:32:20 UTC

Review Request 70501: RANGER-2403 : proper error should be thrown when service part of zone being deleted

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70501/
-----------------------------------------------------------

Review request for ranger, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-2403
    https://issues.apache.org/jira/browse/RANGER-2403


Repository: ranger


Description
-------

currently when service part of zone being deleted ERROR XXService can't be deleted is thrown, we can handle it eg: Service is associated with <abc> and can not be deleted.


Diffs
-----

  security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 17be098 
  security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java 4d46d0e 


Diff: https://reviews.apache.org/r/70501/diff/1/


Testing
-------

1.Validated If proper response comes If user tries to delete service which is present in any zone.


Thanks,

Nikhil P


Re: Review Request 70501: RANGER-2403 : proper error should be thrown when service part of zone being deleted

Posted by Mehul Parikh <me...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70501/#review214875
-----------------------------------------------------------


Ship it!




Ship It!

- Mehul Parikh


On April 18, 2019, 10:32 a.m., Nikhil P wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70501/
> -----------------------------------------------------------
> 
> (Updated April 18, 2019, 10:32 a.m.)
> 
> 
> Review request for ranger, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2403
>     https://issues.apache.org/jira/browse/RANGER-2403
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> currently when service part of zone being deleted ERROR XXService can't be deleted is thrown, we can handle it eg: Service is associated with <abc> and can not be deleted.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 17be098 
>   security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java 4d46d0e 
> 
> 
> Diff: https://reviews.apache.org/r/70501/diff/1/
> 
> 
> Testing
> -------
> 
> 1.Validated If proper response comes If user tries to delete service which is present in any zone.
> 
> 
> Thanks,
> 
> Nikhil P
> 
>


Re: Review Request 70501: RANGER-2403 : proper error should be thrown when service part of zone being deleted

Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70501/#review214821
-----------------------------------------------------------


Ship it!




Ship It!

- Velmurugan Periasamy


On April 18, 2019, 10:32 a.m., Nikhil P wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70501/
> -----------------------------------------------------------
> 
> (Updated April 18, 2019, 10:32 a.m.)
> 
> 
> Review request for ranger, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2403
>     https://issues.apache.org/jira/browse/RANGER-2403
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> currently when service part of zone being deleted ERROR XXService can't be deleted is thrown, we can handle it eg: Service is associated with <abc> and can not be deleted.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 17be098 
>   security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java 4d46d0e 
> 
> 
> Diff: https://reviews.apache.org/r/70501/diff/1/
> 
> 
> Testing
> -------
> 
> 1.Validated If proper response comes If user tries to delete service which is present in any zone.
> 
> 
> Thanks,
> 
> Nikhil P
> 
>