You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2017/09/12 18:28:29 UTC
Review Request 62253: Ignored cgroups v2 hierarchy when parsing
/proc/self/cgroups.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62253/
-----------------------------------------------------------
Review request for mesos and Alexander Rukletsov.
Bugs: MESOS-7969
https://issues.apache.org/jira/browse/MESOS-7969
Repository: mesos
Description
-------
Cgroups v2 hierarchies don't list the "controllers" field (e.g., "0::/user.slice/user-1000.slice/session-5.scope) is empty and hence the cgroup parser failes. We should simply skip over fields with empty controller field.
Diffs
-----
src/linux/cgroups.cpp 95c81d90f956e11d23e965dd0d0b83a66220d858
Diff: https://reviews.apache.org/r/62253/diff/1/
Testing
-------
make check on Fedora 26.
Thanks,
Kapil Arya
Re: Review Request 62253: Ignored cgroups v2 hierarchy when parsing
/proc/self/cgroups.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62253/#review185239
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On Sept. 12, 2017, 6:28 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62253/
> -----------------------------------------------------------
>
> (Updated Sept. 12, 2017, 6:28 p.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Bugs: MESOS-7969
> https://issues.apache.org/jira/browse/MESOS-7969
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Cgroups v2 hierarchies don't list the "controllers" field (e.g., "0::/user.slice/user-1000.slice/session-5.scope) is empty and hence the cgroup parser failes. We should simply skip over fields with empty controller field.
>
>
> Diffs
> -----
>
> src/linux/cgroups.cpp 95c81d90f956e11d23e965dd0d0b83a66220d858
>
>
> Diff: https://reviews.apache.org/r/62253/diff/1/
>
>
> Testing
> -------
>
> make check on Fedora 26.
>
>
> Thanks,
>
> Kapil Arya
>
>