You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "mbutrovich (via GitHub)" <gi...@apache.org> on 2026/09/23 14:50:19 UTC
[I] ci: Stop requiring PR branches to be up to date with `main` before merging [datafusion-iceberg]
mbutrovich opened a new issue, #16:
URL: https://github.com/apache/datafusion-iceberg/issues/16
`.asf.yaml` sets `strict: true` under `required_status_checks` for `main`. This setting came in with #6:
https://github.com/apache/datafusion-iceberg/blob/7ac6084a17e8a5441e769faa24746879495cf552/.asf.yaml#L46-L53
With `strict: true`, a PR can't merge until its branch includes the latest `main`. Whenever another PR merges, every approved PR has to click "Update branch" and wait for CI to run again, even if it has no conflicts. I hit this after #10 merged. My approved PR didn't conflict with #10, but it couldn't merge without another full CI run.
The other DataFusion repos handle this in two different ways:
- `apache/datafusion` lists required checks without `strict`, so it defaults to false. A green PR with no conflicts can merge as it is. The tradeoff is that nothing tests the merged commit on `main` before it lands. https://github.com/apache/datafusion/blob/7570366fd929daf9ced744bb8397686b50565b18/.asf.yaml#L54-L55
- `apache/datafusion-comet` doesn't set `strict` either, but it uses a GitHub merge queue through `.asf.yaml` `rulesets`. Nobody clicks "Update branch", and the queue runs CI on the merged result before it lands. CI still runs once more per merge, and the workflows also need a `merge_group` trigger. https://github.com/apache/datafusion-comet/blob/ef7bda56be6114738bb316b7896c5dc05267e5a3/.asf.yaml#L122-L164
I propose removing `strict: true` to match `apache/datafusion`. If we want the merged result tested before it reaches `main`, the merge queue is the alternative. Which do people prefer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] ci: Stop requiring PR branches to be up to date with `main` before merging [datafusion-iceberg]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed issue #16: ci: Stop requiring PR branches to be up to date with `main` before merging
URL: https://github.com/apache/datafusion-iceberg/issues/16
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org