[jira] Commented: (ZOOKEEPER-874) FileTxnSnapLog.restore does not call listener

["Flavio Junqueira (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12911065#action_12911065 ] 

Flavio Junqueira commented on ZOOKEEPER-874:
--------------------------------------------

The patch is indeed trivial, but I was wondering if we could write a unit test to verify that it is effective in the case you have identified, Diogo.

> FileTxnSnapLog.restore does not call listener
> ---------------------------------------------
>
>                 Key: ZOOKEEPER-874
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-874
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: leaderElection
>    Affects Versions: 3.3.1
>            Reporter: Diogo
>            Priority: Trivial
>             Fix For: 3.4.0
>
>         Attachments: commitlog-listener.patch
>
>
> FileTxnSnapLog.restore() does not call listener passed as parameter. The result is that the commitLogs list is empty. When a follower connects to the leader, the leader is forced to send a snapshot to the follower instead of a couple of requests and commits.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.