You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/09/27 07:10:59 UTC

[GitHub] [flink-ml] zhipeng93 opened a new pull request #9: [hotfix]bugfix in pom and delete some codes in old Flink ML API (as opposed to FLIP-173).

zhipeng93 opened a new pull request #9:
URL: https://github.com/apache/flink-ml/pull/9


   ## What is the purpose of the change
   - make `mvn package` works and delete some code in the old Flink ML API (as opposed to FLIP-173)
   
   ## Brief change log
   - fix bug in flink-ml-lib/pom.xml and flink-ml-uber/pom.xml
   - delete the code that works in old Flink ML API (e.g., EstimatorBase.java,ModelBase.java, PipelineStageBase.java, etc)
   
   
   ## Does this pull request potentially affect one of the following parts:
   - Dependencies (does it add or upgrade a dependency): (no)
   - The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
   - Does this pull request introduce a new feature? (no)
   - If yes, how is the feature documented? (-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-ml] gaoyunhaii closed pull request #9: [hotfix] Fix pom.xml and delete outdated files

Posted by GitBox <gi...@apache.org>.
gaoyunhaii closed pull request #9:
URL: https://github.com/apache/flink-ml/pull/9


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-ml] gaoyunhaii commented on pull request #9: [hotfix] Fix pom.xml and delete outdated files

Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on pull request #9:
URL: https://github.com/apache/flink-ml/pull/9#issuecomment-928711958


   Very thanks @zhipeng93 for opening the PR! LGTM and +1 to merge~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-ml] zhipeng93 commented on pull request #9: [hotfix] Fix pom.xml and delete outdated files

Posted by GitBox <gi...@apache.org>.
zhipeng93 commented on pull request #9:
URL: https://github.com/apache/flink-ml/pull/9#issuecomment-928615913


   > Note that there is typically a space after the tag `[hotfix]`. The PR title typically does not end with `.`.
   
   Hi Dong, thanks for the review. The title is updated.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-ml] lindong28 commented on pull request #9: [hotfix]bugfix in pom and delete some codes in old Flink ML API (as opposed to FLIP-173).

Posted by GitBox <gi...@apache.org>.
lindong28 commented on pull request #9:
URL: https://github.com/apache/flink-ml/pull/9#issuecomment-927991404


   Thanks for the PR. LGTM.
   
   It may be cleaner to use the following words in the commit message and as the PR title:
   
   `[hotfix] Fix pom.xml and delete outdated files`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-ml] lindong28 commented on pull request #9: [hotfix]bugfix in pom and delete some codes in old Flink ML API (as opposed to FLIP-173).

Posted by GitBox <gi...@apache.org>.
lindong28 commented on pull request #9:
URL: https://github.com/apache/flink-ml/pull/9#issuecomment-927998377


   Note that there is typically a space after the tag `[hotfix]`. The PR title typically does not end with `.`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-ml] zhipeng93 commented on pull request #9: [hotfix] Fix pom.xml and delete outdated files

Posted by GitBox <gi...@apache.org>.
zhipeng93 commented on pull request #9:
URL: https://github.com/apache/flink-ml/pull/9#issuecomment-928615913






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-ml] gaoyunhaii commented on pull request #9: [hotfix] Fix pom.xml and delete outdated files

Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on pull request #9:
URL: https://github.com/apache/flink-ml/pull/9#issuecomment-928711958


   Very thanks @zhipeng93 for opening the PR! LGTM and +1 to merge~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-ml] zhipeng93 commented on pull request #9: [hotfix]bugfix in pom and delete some codes in old Flink ML API (as opposed to FLIP-173).

Posted by GitBox <gi...@apache.org>.
zhipeng93 commented on pull request #9:
URL: https://github.com/apache/flink-ml/pull/9#issuecomment-927593999


   @becketqin can you take a quick look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-ml] lindong28 edited a comment on pull request #9: [hotfix]bugfix in pom and delete some codes in old Flink ML API (as opposed to FLIP-173).

Posted by GitBox <gi...@apache.org>.
lindong28 edited a comment on pull request #9:
URL: https://github.com/apache/flink-ml/pull/9#issuecomment-927991404


   Thanks for the PR @zhipeng93. LGTM.
   
   It may be cleaner to use the following words as the commit message and as the PR title:
   
   `[hotfix] Fix pom.xml and delete outdated files`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-ml] gaoyunhaii closed pull request #9: [hotfix] Fix pom.xml and delete outdated files

Posted by GitBox <gi...@apache.org>.
gaoyunhaii closed pull request #9:
URL: https://github.com/apache/flink-ml/pull/9


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-ml] zhipeng93 commented on pull request #9: [hotfix] Fix pom.xml and delete outdated files

Posted by GitBox <gi...@apache.org>.
zhipeng93 commented on pull request #9:
URL: https://github.com/apache/flink-ml/pull/9#issuecomment-928646513


   Hi @gaoyunhaii can you take a look at this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org