svn commit: r1706432 - /subversion/trunk/build/run_tests.py

[ko...@apache.org]

Author: kotkov
Date: Fri Oct  2 15:39:01 2015
New Revision: 1706432

URL: http://svn.apache.org/viewvc?rev=1706432&view=rev
Log:
Following up on r1700215, unbreak the test runner's --bin option.

For instance, win-tests.py --bin=some\path used to error out like this:

  Traceback (most recent call last):
    File "win-tests.py", line 1025, in <module>
      failed = th.run(tests_to_run)
    File "C:\Projects\Subversion\trunk\build\run_tests.py", line 319, in run
      self._init_py_tests(list(py_basedir)[0])
    File "C:\Projects\Subversion\trunk\build\run_tests.py", line 219,
        in _init_py_tests
      cmdline.append('--bin=%s', self.opts.svn_bin)
  TypeError: append() takes exactly one argument (2 given)

* build/run_tests.py
  (TestHarness._init_py_tests): Use % operator to format the --bin path.

Modified:
    subversion/trunk/build/run_tests.py

Modified: subversion/trunk/build/run_tests.py
URL: http://svn.apache.org/viewvc/subversion/trunk/build/run_tests.py?rev=1706432&r1=1706431&r2=1706432&view=diff
==============================================================================
--- subversion/trunk/build/run_tests.py (original)
+++ subversion/trunk/build/run_tests.py Fri Oct  2 15:39:01 2015
@@ -214,7 +214,7 @@ class TestHarness:
       else:
         cmdline.append('--parallel-instances=%d' % self.opts.parallel)
     if self.opts.svn_bin is not None:
-      cmdline.append('--bin=%s', self.opts.svn_bin)
+      cmdline.append('--bin=%s' % self.opts.svn_bin)
     if self.opts.url is not None:
       cmdline.append('--url=%s' % self.opts.url)
     if self.opts.fs_type is not None: