[GitHub] brooklyn-server issue #454: LocalEntityManager: make fields private

[aledsage <gi...@git.apache.org>]

Github user aledsage commented on the issue:

    https://github.com/apache/brooklyn-server/pull/454
  
    @neykov the failing test (`LoopOverGroupMembersTestCaseTest.testMultipleChildrenWhichPass`) is I maybe happening after merging https://github.com/apache/brooklyn-server/pull/452.
    
    It fails because `LoopOverGroupMembersTestCase.start` calls `child.start()` and then immediately checks the child's `SERVICE_STATE_ACTUAL`. This still says "starting" so it does its log.warn, sets `allSuccesful = false`, and thus sets its own serviceState to `ON_FIRE`.
    
    I wonder if child is still reporting `starting` for a few extra milliseconds (set async) because of not doing `onEvent(null)`. I haven't looked into it further yet though.
    
    I wonder if the "correct" fix is for things like `TestSensorImpl.start()` to wait for actual serviceState to be running before the start() method returns (similar to `SoftwareProcessImpl.waitForServiceUp`, but that just waits for serviceUp=true rather than serviceState=running).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---