You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by ASF Subversion and Git Services <as...@urd.zones.apache.org> on 2014/07/30 12:10:40 UTC

Re: Review Request 21554: CLOUDSTACK-6657: Adding condition for checking error code 530 across test cases

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21554/#review49093
-----------------------------------------------------------


Commit a40f2315fdc761309107cc5c88fbd44932edf7e3 in cloudstack's branch refs/heads/4.4 from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a40f231 ]

CLOUDSTACK-6657: Adding condition for checking error code 530 across test cases

Signed-off-by: SrikanteswaraRao Talluri <ta...@apache.org>
(cherry picked from commit 8eca37056f5bb1eee10f0bedee785142d7c3437a)

Conflicts:
	test/integration/smoke/test_network.py


- ASF Subversion and Git Services


On May 16, 2014, 2:03 p.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21554/
> -----------------------------------------------------------
> 
> (Updated May 16, 2014, 2:03 p.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-6657
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6657
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Adding explicit check for error code 530 in the response received form the server wherever applicable.
> I have made these changes in all those files which failed due to having wrong assert (Build #348 KVM regression).
> 
> Will add more of these changes in other files whenever found failing due to above reason in the build logs.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_accounts.py cf5f2b6 
>   test/integration/component/test_add_remove_network.py c17293d 
>   test/integration/component/test_affinity_groups.py d0fa2f7 
>   test/integration/component/test_assign_vm.py 24b63a6 
>   test/integration/component/test_ip_reservation.py c84f63c 
>   test/integration/component/test_non_contiguous_vlan.py 4609af9 
>   test/integration/component/test_projects.py c593fb6 
>   test/integration/component/test_volumes.py b5b08e2 
>   test/integration/component/test_vpc.py e9d396e8 
>   test/integration/component/test_vpc_network.py a449948 
>   test/integration/component/test_vpc_network_lbrules.py a5625e7 
>   test/integration/component/test_vpc_vms_deployment.py 1c1f93d 
>   test/integration/smoke/test_network.py 6beb071 
>   test/integration/smoke/test_nic.py 592a839 
>   test/integration/smoke/test_primary_storage.py 3147d86 
>   test/integration/smoke/test_volumes.py 5908e2b 
> 
> Diff: https://reviews.apache.org/r/21554/diff/
> 
> 
> Testing
> -------
> 
> Tested all test suites with python command.
> Tested only few test suites by running them, not all. Same working change has been applied to all files.
> 
> 
> File Attachments
> ----------------
> 
> Rebased patch against master
>   https://reviews.apache.org/media/uploaded/files/2014/05/16/23566db1-7f6c-46bf-9444-878d9a6e7630__0001-CLOUDSTACK-6657-Adding-condition-for-checking-error-.patch
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>