You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by phrocker <gi...@git.apache.org> on 2017/12/01 17:56:01 UTC
[GitHub] nifi-minifi-cpp pull request #212: MINIFICPP-12: Resolve warnings found duri...
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/212
MINIFICPP-12: Resolve warnings found during compilation
MINIFICPP-12: Remove linux warnings
MINIFICPP-12: Update property and stringutils
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFICPP-12
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/212.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #212
----
commit e25a4b2b630dcf8ca3362f0d61008be06b0762e8
Author: Marc Parisi <ph...@apache.org>
Date: 2017-11-29T14:05:00Z
MINIFICPP-12: Resolve warnings found during compilation
MINIFICPP-12: Remove linux warnings
MINIFICPP-12: Update property and stringutils
----
---
[GitHub] nifi-minifi-cpp pull request #212: MINIFICPP-12: Resolve warnings found duri...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/212
---
[GitHub] nifi-minifi-cpp issue #212: MINIFICPP-12: Resolve warnings found during comp...
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/212
reviewing
---
[GitHub] nifi-minifi-cpp issue #212: MINIFICPP-12: Resolve warnings found during comp...
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/212
Updates look good, thanks! Will get this merged.
---
[GitHub] nifi-minifi-cpp pull request #212: MINIFICPP-12: Resolve warnings found duri...
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/212#discussion_r155021318
--- Diff: CMakeLists.txt ---
@@ -138,18 +145,18 @@ if (NOT DISABLE_LIBARCHIVE)
endif()
option(ENABLE_GPS "Enables the GPS extension." OFF)
-if (ENABLE_GPS)
+if (ENABLE_ALL OR ENABLE_GPS)
--- End diff --
would be good to highlight the ENABLE_ALL in the building section of our README
---
[GitHub] nifi-minifi-cpp issue #212: MINIFICPP-12: Resolve warnings found during comp...
Posted by phrocker <gi...@git.apache.org>.
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/212
This doesn't eliminate every warning. I'll be checking different versions of compilers to see if there is more low hanging fruit.
---