You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by nemo9cby <gi...@git.apache.org> on 2016/10/11 17:02:54 UTC

[GitHub] cloudstack pull request #1705: Made the changes to improve logging.

GitHub user nemo9cby opened a pull request:

    https://github.com/apache/cloudstack/pull/1705

    Made the changes to improve logging.

    This is for resloving the issue of CLOUSTACK-9465
    Several log refactoring/improvement suggestions.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nemo9cby/cloudstack CLOUDSTACK-9465

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1705.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1705
    
----
commit cd9c7737d19c97c95fd536e1ecb4641d4e8651fc
Author: Nemo <ch...@gmail.com>
Date:   2016-10-11T16:58:02Z

    Made the changes to improve logging.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1705: Made the changes to improve logging.

Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:

    https://github.com/apache/cloudstack/pull/1705
  
    @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1705: Made the changes to improve logging.

Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:

    https://github.com/apache/cloudstack/pull/1705
  
    @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1705: Made the changes to improve logging.

Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:

    https://github.com/apache/cloudstack/pull/1705
  
    All changes are in logging, regression tests won't catch anything, but I'll fire a round.
    @blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1705: Made the changes to improve logging.

Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:

    https://github.com/apache/cloudstack/pull/1705
  
    LGTM.
    @blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1705: Made the changes to improve logging.

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cloudstack/pull/1705


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1705: Made the changes to improve logging.

Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:

    https://github.com/apache/cloudstack/pull/1705
  
    Packaging result: \u2714centos6 \u2714centos7 \u2714debian. JID-138


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1705: Made the changes to improve logging.

Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:

    https://github.com/apache/cloudstack/pull/1705
  
    <b>Trillian test result (tid-267)</b>
    Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
    Total time taken: 25657 seconds
    Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1705-t267-kvm-centos7.zip
    Test completed. 48 look ok, 0 have error(s)
    
    
    Test | Result | Time (s) | Test File
    --- | --- | --- | ---
    test_oobm_zchange_password | `Failure` | 20.34 | test_outofbandmanagement.py
    test_01_vpc_site2site_vpn | Success | 172.24 | test_vpc_vpn.py
    test_01_vpc_remote_access_vpn | Success | 65.84 | test_vpc_vpn.py
    test_01_redundant_vpc_site2site_vpn | Success | 265.49 | test_vpc_vpn.py
    test_02_VPC_default_routes | Success | 277.01 | test_vpc_router_nics.py
    test_01_VPC_nics_after_destroy | Success | 556.74 | test_vpc_router_nics.py
    test_05_rvpc_multi_tiers | Success | 510.29 | test_vpc_redundant.py
    test_04_rvpc_network_garbage_collector_nics | Success | 1294.96 | test_vpc_redundant.py
    test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 547.01 | test_vpc_redundant.py
    test_02_redundant_VPC_default_routes | Success | 767.33 | test_vpc_redundant.py
    test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1364.13 | test_vpc_redundant.py
    test_09_delete_detached_volume | Success | 16.40 | test_volumes.py
    test_08_resize_volume | Success | 15.31 | test_volumes.py
    test_07_resize_fail | Success | 20.31 | test_volumes.py
    test_06_download_detached_volume | Success | 15.37 | test_volumes.py
    test_05_detach_volume | Success | 100.22 | test_volumes.py
    test_04_delete_attached_volume | Success | 10.13 | test_volumes.py
    test_03_download_attached_volume | Success | 15.21 | test_volumes.py
    test_02_attach_volume | Success | 78.13 | test_volumes.py
    test_01_create_volume | Success | 739.82 | test_volumes.py
    test_deploy_vm_multiple | Success | 282.52 | test_vm_life_cycle.py
    test_deploy_vm | Success | 0.02 | test_vm_life_cycle.py
    test_advZoneVirtualRouter | Success | 0.01 | test_vm_life_cycle.py
    test_10_attachAndDetach_iso | Success | 26.54 | test_vm_life_cycle.py
    test_09_expunge_vm | Success | 185.17 | test_vm_life_cycle.py
    test_08_migrate_vm | Success | 40.62 | test_vm_life_cycle.py
    test_07_restore_vm | Success | 0.08 | test_vm_life_cycle.py
    test_06_destroy_vm | Success | 125.61 | test_vm_life_cycle.py
    test_03_reboot_vm | Success | 125.59 | test_vm_life_cycle.py
    test_02_start_vm | Success | 10.11 | test_vm_life_cycle.py
    test_01_stop_vm | Success | 40.22 | test_vm_life_cycle.py
    test_CreateTemplateWithDuplicateName | Success | 145.80 | test_templates.py
    test_08_list_system_templates | Success | 0.02 | test_templates.py
    test_07_list_public_templates | Success | 0.02 | test_templates.py
    test_05_template_permissions | Success | 0.03 | test_templates.py
    test_04_extract_template | Success | 5.13 | test_templates.py
    test_03_delete_template | Success | 5.08 | test_templates.py
    test_02_edit_template | Success | 90.15 | test_templates.py
    test_01_create_template | Success | 35.26 | test_templates.py
    test_10_destroy_cpvm | Success | 161.77 | test_ssvm.py
    test_09_destroy_ssvm | Success | 163.49 | test_ssvm.py
    test_08_reboot_cpvm | Success | 101.43 | test_ssvm.py
    test_07_reboot_ssvm | Success | 133.43 | test_ssvm.py
    test_06_stop_cpvm | Success | 131.47 | test_ssvm.py
    test_05_stop_ssvm | Success | 138.47 | test_ssvm.py
    test_04_cpvm_internals | Success | 1.15 | test_ssvm.py
    test_03_ssvm_internals | Success | 3.25 | test_ssvm.py
    test_02_list_cpvm_vm | Success | 0.07 | test_ssvm.py
    test_01_list_sec_storage_vm | Success | 0.08 | test_ssvm.py
    test_01_snapshot_root_disk | Success | 10.84 | test_snapshots.py
    test_04_change_offering_small | Success | 237.20 | test_service_offerings.py
    test_03_delete_service_offering | Success | 0.03 | test_service_offerings.py
    test_02_edit_service_offering | Success | 0.04 | test_service_offerings.py
    test_01_create_service_offering | Success | 0.07 | test_service_offerings.py
    test_02_sys_template_ready | Success | 0.08 | test_secondary_storage.py
    test_01_sys_vm_start | Success | 0.11 | test_secondary_storage.py
    test_09_reboot_router | Success | 35.22 | test_routers.py
    test_08_start_router | Success | 30.19 | test_routers.py
    test_07_stop_router | Success | 10.10 | test_routers.py
    test_06_router_advanced | Success | 0.04 | test_routers.py
    test_05_router_basic | Success | 0.03 | test_routers.py
    test_04_restart_network_wo_cleanup | Success | 5.60 | test_routers.py
    test_03_restart_network_cleanup | Success | 65.40 | test_routers.py
    test_02_router_internal_adv | Success | 1.03 | test_routers.py
    test_01_router_internal_basic | Success | 0.56 | test_routers.py
    test_router_dns_guestipquery | Success | 76.64 | test_router_dns.py
    test_router_dns_externalipquery | Success | 0.06 | test_router_dns.py
    test_router_dhcphosts | Success | 276.14 | test_router_dhcphosts.py
    test_01_updatevolumedetail | Success | 0.05 | test_resource_detail.py
    test_01_reset_vm_on_reboot | Success | 160.73 | test_reset_vm_on_reboot.py
    test_createRegion | Success | 0.03 | test_regions.py
    test_create_pvlan_network | Success | 5.14 | test_pvlan.py
    test_dedicatePublicIpRange | Success | 0.27 | test_public_ip_range.py
    test_04_rvpc_privategw_static_routes | Success | 519.89 | test_privategw_acl.py
    test_03_vpc_privategw_restart_vpc_cleanup | Success | 498.47 | test_privategw_acl.py
    test_02_vpc_privategw_static_routes | Success | 429.09 | test_privategw_acl.py
    test_01_vpc_privategw_acl | Success | 87.04 | test_privategw_acl.py
    test_01_primary_storage_nfs | Success | 35.67 | test_primary_storage.py
    test_createPortablePublicIPRange | Success | 15.12 | test_portable_publicip.py
    test_createPortablePublicIPAcquire | Success | 15.27 | test_portable_publicip.py
    test_isolate_network_password_server | Success | 90.31 | test_password_server.py
    test_UpdateStorageOverProvisioningFactor | Success | 0.14 | test_over_provisioning.py
    test_oobm_multiple_mgmt_server_ownership | Success | 16.52 | test_outofbandmanagement.py
    test_oobm_issue_power_status | Success | 10.51 | test_outofbandmanagement.py
    test_oobm_issue_power_soft | Success | 15.51 | test_outofbandmanagement.py
    test_oobm_issue_power_reset | Success | 15.51 | test_outofbandmanagement.py
    test_oobm_issue_power_on | Success | 15.51 | test_outofbandmanagement.py
    test_oobm_issue_power_off | Success | 15.51 | test_outofbandmanagement.py
    test_oobm_issue_power_cycle | Success | 15.51 | test_outofbandmanagement.py
    test_oobm_enabledisable_across_clusterzones | Success | 61.93 | test_outofbandmanagement.py
    test_oobm_enable_feature_valid | Success | 5.12 | test_outofbandmanagement.py
    test_oobm_enable_feature_invalid | Success | 0.08 | test_outofbandmanagement.py
    test_oobm_disable_feature_valid | Success | 0.17 | test_outofbandmanagement.py
    test_oobm_disable_feature_invalid | Success | 0.07 | test_outofbandmanagement.py
    test_oobm_configure_invalid_driver | Success | 0.07 | test_outofbandmanagement.py
    test_oobm_configure_default_driver | Success | 0.06 | test_outofbandmanagement.py
    test_oobm_background_powerstate_sync | Success | 29.57 | test_outofbandmanagement.py
    test_extendPhysicalNetworkVlan | Success | 15.21 | test_non_contigiousvlan.py
    test_01_nic | Success | 624.16 | test_nic.py
    test_releaseIP | Success | 267.55 | test_network.py
    test_reboot_router | Success | 428.14 | test_network.py
    test_public_ip_user_account | Success | 10.18 | test_network.py
    test_public_ip_admin_account | Success | 40.19 | test_network.py
    test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Success | 66.73 | test_network.py
    test_network_rules_acquired_public_ip_2_nat_rule | Success | 61.43 | test_network.py
    test_network_rules_acquired_public_ip_1_static_nat_rule | Success | 124.05 | test_network.py
    test_delete_account | Success | 267.59 | test_network.py
    test_02_port_fwd_on_non_src_nat | Success | 55.57 | test_network.py
    test_01_port_fwd_on_src_nat | Success | 111.63 | test_network.py
    test_nic_secondaryip_add_remove | Success | 202.26 | test_multipleips_per_nic.py
    login_test_saml_user | Success | 21.25 | test_login.py
    test_assign_and_removal_lb | Success | 133.46 | test_loadbalance.py
    test_02_create_lb_rule_non_nat | Success | 192.78 | test_loadbalance.py
    test_01_create_lb_rule_src_nat | Success | 227.79 | test_loadbalance.py
    test_03_list_snapshots | Success | 0.05 | test_list_ids_parameter.py
    test_02_list_templates | Success | 0.02 | test_list_ids_parameter.py
    test_01_list_volumes | Success | 0.02 | test_list_ids_parameter.py
    test_07_list_default_iso | Success | 0.04 | test_iso.py
    test_05_iso_permissions | Success | 0.04 | test_iso.py
    test_04_extract_Iso | Success | 5.16 | test_iso.py
    test_03_delete_iso | Success | 95.08 | test_iso.py
    test_02_edit_iso | Success | 0.04 | test_iso.py
    test_01_create_iso | Success | 21.22 | test_iso.py
    test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Success | 343.54 | test_internal_lb.py
    test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Success | 222.63 | test_internal_lb.py
    test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Success | 518.54 | test_internal_lb.py
    test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Success | 477.21 | test_internal_lb.py
    test_dedicateGuestVlanRange | Success | 10.17 | test_guest_vlan_range.py
    test_UpdateConfigParamWithScope | Success | 0.09 | test_global_settings.py
    test_rolepermission_lifecycle_update | Success | 6.33 | test_dynamicroles.py
    test_rolepermission_lifecycle_list | Success | 6.20 | test_dynamicroles.py
    test_rolepermission_lifecycle_delete | Success | 6.13 | test_dynamicroles.py
    test_rolepermission_lifecycle_create | Success | 6.16 | test_dynamicroles.py
    test_rolepermission_lifecycle_concurrent_updates | Success | 6.23 | test_dynamicroles.py
    test_role_lifecycle_update_role_inuse | Success | 6.19 | test_dynamicroles.py
    test_role_lifecycle_update | Success | 11.23 | test_dynamicroles.py
    test_role_lifecycle_list | Success | 6.22 | test_dynamicroles.py
    test_role_lifecycle_delete | Success | 11.20 | test_dynamicroles.py
    test_role_lifecycle_create | Success | 6.17 | test_dynamicroles.py
    test_role_inuse_deletion | Success | 6.14 | test_dynamicroles.py
    test_role_account_acls_multiple_mgmt_servers | Success | 7.51 | test_dynamicroles.py
    test_role_account_acls | Success | 7.74 | test_dynamicroles.py
    test_default_role_deletion | Success | 6.22 | test_dynamicroles.py
    test_04_create_fat_type_disk_offering | Success | 0.05 | test_disk_offerings.py
    test_03_delete_disk_offering | Success | 0.03 | test_disk_offerings.py
    test_02_edit_disk_offering | Success | 0.03 | test_disk_offerings.py
    test_02_create_sparse_type_disk_offering | Success | 0.04 | test_disk_offerings.py
    test_01_create_disk_offering | Success | 0.07 | test_disk_offerings.py
    test_deployvm_userdispersing | Success | 45.46 | test_deploy_vms_with_varied_deploymentplanners.py
    test_deployvm_userconcentrated | Success | 20.37 | test_deploy_vms_with_varied_deploymentplanners.py
    test_deployvm_firstfit | Success | 50.39 | test_deploy_vms_with_varied_deploymentplanners.py
    test_deployvm_userdata_post | Success | 35.36 | test_deploy_vm_with_userdata.py
    test_deployvm_userdata | Success | 55.46 | test_deploy_vm_with_userdata.py
    test_02_deploy_vm_root_resize | Success | 6.21 | test_deploy_vm_root_resize.py
    test_01_deploy_vm_root_resize | Success | 6.20 | test_deploy_vm_root_resize.py
    test_00_deploy_vm_root_resize | Success | 227.30 | test_deploy_vm_root_resize.py
    test_deploy_vm_from_iso | Success | 207.28 | test_deploy_vm_iso.py
    test_DeployVmAntiAffinityGroup | Success | 65.62 | test_affinity_groups.py
    test_03_delete_vm_snapshots | Skipped | 0.00 | test_vm_snapshots.py
    test_02_revert_vm_snapshots | Skipped | 0.00 | test_vm_snapshots.py
    test_01_test_vm_volume_snapshot | Skipped | 0.00 | test_vm_snapshots.py
    test_01_create_vm_snapshots | Skipped | 0.00 | test_vm_snapshots.py
    test_06_copy_template | Skipped | 0.00 | test_templates.py
    test_static_role_account_acls | Skipped | 0.01 | test_staticroles.py
    test_01_scale_vm | Skipped | 0.00 | test_scale_vm.py
    test_01_primary_storage_iscsi | Skipped | 0.02 | test_primary_storage.py
    test_06_copy_iso | Skipped | 0.00 | test_iso.py
    test_deploy_vgpu_enabled_vm | Skipped | 0.02 | test_deploy_vgpu_enabled_vm.py
    test_3d_gpu_support | Skipped | 0.02 | test_deploy_vgpu_enabled_vm.py



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1705: Made the changes to improve logging.

Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:

    https://github.com/apache/cloudstack/pull/1705
  
    Packaging result: \u2714centos6 \u2714centos7 \u2714debian. JID-70


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1705: Made the changes to improve logging.

Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:

    https://github.com/apache/cloudstack/pull/1705
  
    Merging based on code review and test LGTM. The one failing test is intermittent and caused by the environment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1705: Made the changes to improve logging.

Posted by wido <gi...@git.apache.org>.
Github user wido commented on the issue:

    https://github.com/apache/cloudstack/pull/1705
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1705: Made the changes to improve logging.

Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:

    https://github.com/apache/cloudstack/pull/1705
  
    @blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1705: Made the changes to improve logging.

Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:

    https://github.com/apache/cloudstack/pull/1705
  
    @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---