[GitHub] [incubator-pekko-persistence-cassandra] mdedetrich commented on a diff in pull request #99: Add applyCodeStyle and checkCodeStyle command alias

["mdedetrich (via GitHub)" <gi...@apache.org>]

mdedetrich commented on code in PR #99:
URL: https://github.com/apache/incubator-pekko-persistence-cassandra/pull/99#discussion_r1318480245


##########
build.sbt:
##########
@@ -20,6 +20,10 @@ commands := commands.value.filterNot { command =>
   }
 }
 
+addCommandAlias("applyCodeStyle", ";scalafmtAll; scalafmtSbt; javafmtAll; docs/javafmtAll; +headerCreateAll")
+addCommandAlias("checkCodeStyle",
+  "+;headerCheckAll; scalafmtCheckAll; scalafmtSbtCheck; javafmtCheckAll; docs/javafmtCheckAll")

Review Comment:
   `"; +headerCheckAll` no, this is a bug that prevents the command from running and I had to fix it in other places.
   
   > And we can better introduce a plugin for this, @mdedetrich can you add these to sbt-apache-sonatype
   
   This does not belong in sbt-apache-sonatype, it would be a new sbt plugin that is specifically designed for pekko projects.



##########
build.sbt:
##########
@@ -20,6 +20,10 @@ commands := commands.value.filterNot { command =>
   }
 }
 
+addCommandAlias("applyCodeStyle", ";scalafmtAll; scalafmtSbt; javafmtAll; docs/javafmtAll; +headerCreateAll")
+addCommandAlias("checkCodeStyle",
+  "+;headerCheckAll; scalafmtCheckAll; scalafmtSbtCheck; javafmtCheckAll; docs/javafmtCheckAll")

Review Comment:
   `"; +headerCheckAll` no, this is a bug that prevents the command from running and I had to fix it in other projects.
   
   > And we can better introduce a plugin for this, @mdedetrich can you add these to sbt-apache-sonatype
   
   This does not belong in sbt-apache-sonatype, it would be a new sbt plugin that is specifically designed for pekko projects.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org