You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/02/27 02:15:39 UTC

[GitHub] sijie opened a new pull request #1295: Use log4j2 as slf4j binding for tests

sijie opened a new pull request #1295: Use log4j2 as slf4j binding for tests
URL: https://github.com/apache/incubator-pulsar/pull/1295
 
 
   ### Motivation
   
   in pulsar-functions, we are using log4j2 routing appender for logging. so pulsar-functions is using log4j2, if we are using `slf4j-simple` in the tests, it will cause all the bindings conflict. so the change is propose to move tests to use log4j2 slf4j binding, instead of `slf4j-simple`
   
   ### Modifications
   
   - replace `slf4j-simple` with log4j2 bindings in tests
   - to avoid copying the log4j2 property files to every modules, we make a default log4j2 property file in buildtools module, and make buildtools module as a default test dependency for every modules.
   
   ### Result
   
   - use log4j2 binding for tests
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services