Re: [PR] IGNITE-25583 Sql. Implement direct mapping for explicit transactions [ignite-3]

["zstan (via GitHub)" <gi...@apache.org>]

zstan commented on code in PR #6235:
URL: https://github.com/apache/ignite-3/pull/6235#discussion_r2206647966


##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/prepare/partitionawareness/PartitionAwarenessMetadataTest.java:
##########
@@ -165,9 +165,9 @@ private static Stream<Arguments> shortKeyMetadata() {
                 Arguments.of("SELECT * FROM t WHERE c1=? and c2=? and c3=3", null),
 
                 // KV PUT
-                Arguments.of("INSERT INTO t VALUES (?, ?, ?)",  dynamicParams(2)),
-                Arguments.of("INSERT INTO t (c1, c2, c3) VALUES (?, ?, ?)", dynamicParams(2)),
-                Arguments.of("INSERT INTO t (c3, c1, c2) VALUES (?, ?, ?)", dynamicParams(0)),
+                Arguments.of("INSERT INTO t VALUES (?, ?, ?)",  dynamicParamsTrackingRequired(2)),

Review Comment:
   lets also add :
   ```
   Arguments.of("SELECT * FROM t WHERE c3=? and c2=1", dynamicParams(0)),
   Arguments.of("SELECT * FROM t WHERE c1=1 and c2=? and c3=?", dynamicParams(1)),
   ```



##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/sql/ClientSqlExecuteRequest.java:
##########
@@ -79,12 +83,21 @@ public static CompletableFuture<ResponseWriter> process(
             ClientResourceRegistry resources,
             ClientHandlerMetricSource metrics,
             HybridTimestampTracker timestampTracker,
-            boolean sqlPartitionAwarenessSupported
+            boolean sqlPartitionAwarenessSupported,

Review Comment:
   append params to java doc plz



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org