You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/11/05 09:13:42 UTC
[GitHub] [rocketmq] humkum opened a new pull request, #5468: [ISSUE #5437] Add log info for push consumer when execute hook failed
humkum opened a new pull request, #5468:
URL: https://github.com/apache/rocketmq/pull/5468
closes https://github.com/apache/rocketmq/issues/5437
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #5468: [ISSUE #5437] Add log info for push consumer when execute hook failed
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #5468:
URL: https://github.com/apache/rocketmq/pull/5468#issuecomment-1304459167
# [Codecov](https://codecov.io/gh/apache/rocketmq/pull/5468?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#5468](https://codecov.io/gh/apache/rocketmq/pull/5468?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (74af205) into [develop](https://codecov.io/gh/apache/rocketmq/commit/dd95a5b9c8941ba41096ee6fc6b8c4330d946dcb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dd95a5b) will **increase** coverage by `0.00%`.
> The diff coverage is `31.01%`.
```diff
@@ Coverage Diff @@
## develop #5468 +/- ##
===========================================
Coverage 43.17% 43.17%
- Complexity 8050 8061 +11
===========================================
Files 1021 1025 +4
Lines 71999 72196 +197
Branches 9537 9560 +23
===========================================
+ Hits 31082 31171 +89
- Misses 36985 37077 +92
- Partials 3932 3948 +16
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/5468?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...a/org/apache/rocketmq/broker/BrokerController.java](https://codecov.io/gh/apache/rocketmq/pull/5468/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvQnJva2VyQ29udHJvbGxlci5qYXZh) | `46.44% <0.00%> (+2.67%)` | :arrow_up: |
| [...rocketmq/broker/metrics/BrokerMetricsConstant.java](https://codecov.io/gh/apache/rocketmq/pull/5468/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvbWV0cmljcy9Ccm9rZXJNZXRyaWNzQ29uc3RhbnQuamF2YQ==) | `0.00% <ø> (ø)` | |
| [.../rocketmq/broker/metrics/NopLongUpDownCounter.java](https://codecov.io/gh/apache/rocketmq/pull/5468/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvbWV0cmljcy9Ob3BMb25nVXBEb3duQ291bnRlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ocketmq/broker/processor/PeekMessageProcessor.java](https://codecov.io/gh/apache/rocketmq/pull/5468/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL1BlZWtNZXNzYWdlUHJvY2Vzc29yLmphdmE=) | `3.40% <0.00%> (-0.20%)` | :arrow_down: |
| [...he/rocketmq/broker/processor/PopReviveService.java](https://codecov.io/gh/apache/rocketmq/pull/5468/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL1BvcFJldml2ZVNlcnZpY2UuamF2YQ==) | `40.56% <0.00%> (-0.92%)` | :arrow_down: |
| [.../transaction/queue/TransactionalMessageBridge.java](https://codecov.io/gh/apache/rocketmq/pull/5468/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvdHJhbnNhY3Rpb24vcXVldWUvVHJhbnNhY3Rpb25hbE1lc3NhZ2VCcmlkZ2UuamF2YQ==) | `69.51% <0.00%> (-2.71%)` | :arrow_down: |
| [...lient/impl/consumer/DefaultMQPushConsumerImpl.java](https://codecov.io/gh/apache/rocketmq/pull/5468/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9EZWZhdWx0TVFQdXNoQ29uc3VtZXJJbXBsLmphdmE=) | `32.12% <0.00%> (-0.09%)` | :arrow_down: |
| [...he/rocketmq/common/attribute/TopicMessageType.java](https://codecov.io/gh/apache/rocketmq/pull/5468/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vYXR0cmlidXRlL1RvcGljTWVzc2FnZVR5cGUuamF2YQ==) | `91.66% <0.00%> (-8.34%)` | :arrow_down: |
| [.../apache/rocketmq/common/utils/ServiceProvider.java](https://codecov.io/gh/apache/rocketmq/pull/5468/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vdXRpbHMvU2VydmljZVByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...org/apache/rocketmq/store/DefaultMessageStore.java](https://codecov.io/gh/apache/rocketmq/pull/5468/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0RlZmF1bHRNZXNzYWdlU3RvcmUuamF2YQ==) | `53.62% <0.00%> (+0.04%)` | :arrow_up: |
| ... and [31 more](https://codecov.io/gh/apache/rocketmq/pull/5468/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] lizhanhui commented on pull request #5468: [ISSUE #5437] Add log info for push consumer when execute hook failed
Posted by GitBox <gi...@apache.org>.
lizhanhui commented on PR #5468:
URL: https://github.com/apache/rocketmq/pull/5468#issuecomment-1305029179
Rebase to make all CI pipelines pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] lizhanhui merged pull request #5468: [ISSUE #5437] Add log info for push consumer when execute hook failed
Posted by GitBox <gi...@apache.org>.
lizhanhui merged PR #5468:
URL: https://github.com/apache/rocketmq/pull/5468
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org