You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by GitBox <gi...@apache.org> on 2022/12/17 18:31:57 UTC
[GitHub] [knox] lmccay commented on a diff in pull request #681: KNOX-2839 - Identity assertion provider handles Hadoop ProxyUser auth using the 'doAs' query parameter
lmccay commented on code in PR #681:
URL: https://github.com/apache/knox/pull/681#discussion_r1051439950
##########
gateway-release/home/conf/topologies/homepage.xml:
##########
@@ -60,6 +60,24 @@
<role>identity-assertion</role>
<name>Default</name>
<enabled>true</enabled>
+ <!--
+ <param>
+ <name>haddop.proxyuser.impersonation.enabled</name>
+ <value>false</value>
+ </param>
+ <param>
+ <name>haddop.proxyuser.admin.users</name>
+ <value>*</value>
+ </param>
+ <param>
+ <name>hadoop.proxyuser.admin.groups</name>
+ <value>*</value>
+ </param>
+ <param>
+ <name>hadoop.proxyuser.admin.hosts</name>
+ <value>*</value>
+ </param>
+ -->
Review Comment:
Why is this commented out here, just a convenience? Will these comment survive an admin ui read/save?
##########
gateway-release/home/conf/topologies/homepage.xml:
##########
@@ -60,6 +60,24 @@
<role>identity-assertion</role>
<name>Default</name>
<enabled>true</enabled>
+ <!--
+ <param>
+ <name>haddop.proxyuser.impersonation.enabled</name>
+ <value>false</value>
+ </param>
+ <param>
+ <name>haddop.proxyuser.admin.users</name>
+ <value>*</value>
+ </param>
+ <param>
+ <name>hadoop.proxyuser.admin.groups</name>
+ <value>*</value>
+ </param>
+ <param>
+ <name>hadoop.proxyuser.admin.hosts</name>
+ <value>*</value>
+ </param>
+ -->
Review Comment:
If impersonation.enabled defaults to false then why do we need to comment them out?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org