Re: [PR] KAFKA-20263: Change KeyValueStoreWrapper to have versioned and headersStore [kafka]

["mjsax (via GitHub)" <gi...@apache.org>]

mjsax commented on code in PR #21580:
URL: https://github.com/apache/kafka/pull/21580#discussion_r2963398380


##########
streams/src/main/java/org/apache/kafka/streams/state/internals/KeyValueStoreWrapper.java:
##########
@@ -45,70 +49,72 @@ public class KeyValueStoreWrapper<K, V> implements StateStore {
     public static final long PUT_RETURN_CODE_IS_LATEST
         = VersionedKeyValueStore.PUT_RETURN_CODE_VALID_TO_UNDEFINED;
 
-    private TimestampedKeyValueStore<K, V> timestampedStore = null;
+    private TimestampedKeyValueStoreWithHeaders<K, V> headersStore = null;
     private VersionedKeyValueStore<K, V> versionedStore = null;
 
     // same as either timestampedStore or versionedStore above. kept merely as a convenience
     // to simplify implementation for methods which do not depend on store type.
     private StateStore store;
 
+    @SuppressWarnings("unchecked")
     public KeyValueStoreWrapper(final ProcessorContext<?, ?> context, final String storeName) {
+        final StateStore rawStore = context.getStateStore(storeName);

Review Comment:
   Addressed via https://github.com/apache/kafka/pull/21792



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org