You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "elharo (via GitHub)" <gi...@apache.org> on 2023/02/19 14:06:32 UTC

[GitHub] [maven-doxia-sitetools] elharo commented on a diff in pull request #86: [DOXIASITETOOLS-291] Add timezone field to site descriptor PublishDat…

elharo commented on code in PR #86:
URL: https://github.com/apache/maven-doxia-sitetools/pull/86#discussion_r1111243492


##########
doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java:
##########
@@ -434,6 +435,10 @@ protected Context createToolManagedVelocityContext(SiteRenderingContext siteRend
         Locale locale = siteRenderingContext.getLocale();
         String dateFormat =
                 siteRenderingContext.getDecoration().getPublishDate().getFormat();
+        String timezoneId =

Review Comment:
   nit: timeZoneId



##########
doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java:
##########
@@ -434,6 +435,10 @@ protected Context createToolManagedVelocityContext(SiteRenderingContext siteRend
         Locale locale = siteRenderingContext.getLocale();
         String dateFormat =
                 siteRenderingContext.getDecoration().getPublishDate().getFormat();
+        String timezoneId =
+                siteRenderingContext.getDecoration().getPublishDate().getTimezone();
+        TimeZone timezone =

Review Comment:
   nit: timeZone



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org