You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Mathias Weinert <ma...@gfa-net.de> on 2005/11/17 13:54:45 UTC
[PATCH] Building Subversion Perl Bindings under cygwin
Hi there,
Please find enclosed three patches I have to apply
(1.3.0-rc2) to be able to build the Subversion Perl
bindings under cygwin (in addition to the ones Max Bowsher
created in the official cygwin distribution).
I wonder why others (e. g. Max) don't need these patches.
Is it a problem of my configuration or will everybody
need it?
Mathias
---------------------------------
--- subversion/bindings/swig/core.i.orig 2005-10-25 21:03:21.000000000 +0200
+++ subversion/bindings/swig/core.i 2005-11-14 11:03:19.057069100 +0100
@@ -627,6 +627,11 @@
%include svn_md5_h.swg
%include svn_diff_h.swg
%include svn_error_h.swg
+
+%init %{
+ svn_swig_pl_bind_current_pool_fns (&svn_swig_pl_get_current_pool,
+ &svn_swig_pl_set_current_pool);
+%}
#endif
#ifdef SWIGPYTHON
--- subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.c.orig 2005-09-23 12:39:32.000000000 +0200
+++ subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.c 2005-09-23 16:16:19.088242000 +0200
@@ -1208,8 +1208,16 @@
/* default pool support */
-apr_pool_t *svn_swig_pl_get_current_pool (void);
-void svn_swig_pl_set_current_pool (apr_pool_t *pool);
+static svn_swig_pl_get_current_pool_t svn_swig_pl_get_current_pool = NULL;
+static svn_swig_pl_set_current_pool_t svn_swig_pl_set_current_pool = NULL;
+
+void svn_swig_pl_bind_current_pool_fns (svn_swig_pl_get_current_pool_t get,
+ svn_swig_pl_set_current_pool_t set)
+{
+ svn_swig_pl_get_current_pool = get;
+ svn_swig_pl_set_current_pool = set;
+}
+
apr_pool_t *svn_swig_pl_make_pool (SV *obj)
{
--- subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.h.orig 2005-09-23 12:39:32.000000000 +0200
+++ subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.h 2005-09-23 16:20:57.375065800 +0200
@@ -50,6 +50,12 @@
+typedef apr_pool_t *(*svn_swig_pl_get_current_pool_t) (void);
+typedef void (*svn_swig_pl_set_current_pool_t) (apr_pool_t *pool);
+
+void svn_swig_pl_bind_current_pool_fns (svn_swig_pl_get_current_pool_t get,
+ svn_swig_pl_set_current_pool_t set);
+
apr_pool_t *svn_swig_pl_make_pool (SV *obj);
typedef enum perl_func_invoker {
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Building Subversion Perl Bindings under cygwin
Posted by Max Bowsher <ma...@ukf.net>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Mathias Weinert wrote:
> Hi there,
>
> Please find enclosed three patches I have to apply
> (1.3.0-rc2) to be able to build the Subversion Perl
> bindings under cygwin (in addition to the ones Max Bowsher
> created in the official cygwin distribution).
>
> I wonder why others (e. g. Max) don't need these patches.
> Is it a problem of my configuration or will everybody
> need it?
The patches you sent are not in addition to those I created in the
official cygwin distribution - they are exactly those patches, no more,
no less.
They are unsuitable for committing to Subversion as-is, as they would
break the perl bindings on Windows, where libsvn_swig_perl is compiled
as a static library.
I have, in fact, already committed suitably conditionalized versions of
these patches to trunk. I do not intend to backport them to the 1.3.x
release branch, because they have exposed a bug in the build dependency
generator, which I am currently engaged in fixing, and which seems to be
a fairly complex fix.
Max.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (Cygwin)
iD8DBQFDfJzDfFNSmcDyxYARApVNAJ41rWr5ooKbMJK4aOymKpIk0Cef3wCfY9hf
bCo6aVWH1JOEipU2kBQKoAo=
=kKIn
-----END PGP SIGNATURE-----
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org